Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1619497
| From | Carlo Caione <carlo@caione.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH 1/2] hp-wmi: Fix error value for hp_wmi_tablet_state |
| Date | 2017-04-09 16:00 +0200 |
| Message-ID | <tulxM-3uX-7@gated-at.bofh.it> (permalink) |
| References | <tulxM-3uX-9@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Carlo Caione <carlo@endlessm.com> hp_wmi_tablet_state() fails to return the correct error code when hp_wmi_perform_query() returns the HP WMI query specific error code that is a positive value. Signed-off-by: Carlo Caione <carlo@endlessm.com> --- drivers/platform/x86/hp-wmi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/platform/x86/hp-wmi.c b/drivers/platform/x86/hp-wmi.c index 96ffda4..13ba65c 100644 --- a/drivers/platform/x86/hp-wmi.c +++ b/drivers/platform/x86/hp-wmi.c @@ -290,7 +290,7 @@ static int hp_wmi_tablet_state(void) int ret = hp_wmi_perform_query(HPWMI_HARDWARE_QUERY, 0, &state, sizeof(state), sizeof(state)); if (ret) - return ret; + return -EINVAL; return (state & 0x4) ? 1 : 0; } -- 2.9.3
Back to linux.kernel | Previous | Next | Find similar | Unroll thread
[PATCH 1/2] hp-wmi: Fix error value for hp_wmi_tablet_state Carlo Caione <carlo@caione.org> - 2017-04-09 16:00 +0200
csiph-web