Re: [PATCH v4 2/2] crypto: hw_random - Add new Exynos RNG driver

From	Krzysztof Kozlowski <krzk@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 2/2] crypto: hw_random - Add new Exynos RNG driver
Date	2017-04-11 10:20 +0200
Message-ID	<tuZbP-4s3-3@gated-at.bofh.it> (permalink)
References	<ttYKR-5SE-1@gated-at.bofh.it> <ttYKR-5SE-7@gated-at.bofh.it> <tuFd7-80c-7@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 10, 2017 at 12:55 PM, Herbert Xu
<herbert@gondor.apana.org.au> wrote:
> On Sat, Apr 08, 2017 at 03:32:45PM +0200, Krzysztof Kozlowski wrote:
>>
>> +static struct rng_alg exynos_rng_alg = {
>> +     .generate               = exynos_rng_generate,
>> +     .seed                   = exynos_rng_seed,
>> +     .seedsize               = EXYNOS_RNG_SEED_SIZE,
>> +     .base                   = {
>> +             .cra_name               = "exynos_rng",
>
> Please use stdrng.  Or is there a reason why this can't be used
> by the crypto layer itself?

I think there is no reason against, I'll fix it.

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v4 2/2] crypto: hw_random - Add new Exynos RNG driver Krzysztof Kozlowski <krzk@kernel.org> - 2017-04-11 10:20 +0200

csiph-web