Groups > linux.kernel > #1620953

Re: linux-next: manual merge of the crypto tree with the kbuild tree

From	Herbert Xu <herbert@gondor.apana.org.au>
Newsgroups	linux.kernel
Subject	Re: linux-next: manual merge of the crypto tree with the kbuild tree
Date	2017-04-11 08:50 +0200
Message-ID	<tuXMJ-3sI-5@gated-at.bofh.it> (permalink)
References	<tuRQZ-850-13@gated-at.bofh.it> <tuU2t-12b-7@gated-at.bofh.it> <tuWdY-2Cp-13@gated-at.bofh.it> <tuWnE-2G5-9@gated-at.bofh.it> <tuXD3-3po-17@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Apr 11, 2017 at 03:34:43PM +0900, Masahiro Yamada wrote:
> Hi Herbert,
> 
> 
> 2017-04-11 14:12 GMT+09:00 Herbert Xu <herbert@gondor.apana.org.au>:
> > On Tue, Apr 11, 2017 at 03:02:50PM +1000, Stephen Rothwell wrote:
> >>
> >> So basically we need CRYPTO_MAX_ALG_NAME to be 64 in the exported
> >> header but 128 in the kernel header?  In which case the kbuild patch
> >> needs to be changed not removed.  Or the merge resolution needs to be
> >> cleverer.
> >
> > Actually the kbuild patch just needs to be reverted.  We should
> > not export CRYPTO_MAX_ALG_NAME at all.  Each user-space interface
> > that uses it already has its own limit and should not refer to the
> > in-kernel value.
> 
> CRYPTO_MAX_ALG_NAME is referenced from
> include/uapi/linux/cryptouser.h
> 
> If you exporting CRYPTO_MAX_ALG_NAME is wrong,
> please move cryptouser.h out of the include/uapi directory.

It doesn't reference it anymore in the latest cryptodev tree.

So please revert the patch from the kbuild tree.

Thanks,
-- 
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt

Thread

linux-next: manual merge of the crypto tree with the kbuild tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-04-11 02:30 +0200
  Re: linux-next: manual merge of the crypto tree with the kbuild tree Herbert Xu <herbert@gondor.apana.org.au> - 2017-04-11 04:50 +0200
    Re: linux-next: manual merge of the crypto tree with the kbuild  tree Stephen Rothwell <sfr@canb.auug.org.au> - 2017-04-11 07:10 +0200
      Re: linux-next: manual merge of the crypto tree with the kbuild tree Herbert Xu <herbert@gondor.apana.org.au> - 2017-04-11 07:20 +0200
        Re: linux-next: manual merge of the crypto tree with the kbuild tree Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-11 08:40 +0200
          Re: linux-next: manual merge of the crypto tree with the kbuild tree Herbert Xu <herbert@gondor.apana.org.au> - 2017-04-11 08:50 +0200
            Re: linux-next: manual merge of the crypto tree with the kbuild tree Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-11 09:10 +0200
              Re: linux-next: manual merge of the crypto tree with the kbuild tree Herbert Xu <herbert@gondor.apana.org.au> - 2017-04-11 09:30 +0200
      Re: linux-next: manual merge of the crypto tree with the kbuild tree Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-11 10:00 +0200
        Re: linux-next: manual merge of the crypto tree with the kbuild tree Herbert Xu <herbert@gondor.apana.org.au> - 2017-04-11 11:30 +0200

csiph-web