Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1620890
| From | Logan Gunthorpe <logang@deltatee.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH] switchtec: Fix an error handling |
| Date | 2017-04-11 06:40 +0200 |
| Message-ID | <tuVKW-2cx-7@gated-at.bofh.it> (permalink) |
| References | <tuVKV-2cx-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Nice catch. Thanks.
Reviewed-by: Logan Gunthorpe <logang@deltatee.com>
Logan
On 10/04/17 10:32 PM, Christophe JAILLET wrote:
> 'stuser_create' returns an error pointer in case of error, not NULL.
> So test its return value with IS_ERR.
>
> Fixes: 74004262f329 ("MicroSemi Switchtec management interface driver")
>
> Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr>
> ---
> drivers/pci/switch/switchtec.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/pci/switch/switchtec.c b/drivers/pci/switch/switchtec.c
> index fcde98161d9a..cc6e085008fb 100644
> --- a/drivers/pci/switch/switchtec.c
> +++ b/drivers/pci/switch/switchtec.c
> @@ -608,7 +608,7 @@ static int switchtec_dev_open(struct inode *inode, struct file *filp)
> stdev = container_of(inode->i_cdev, struct switchtec_dev, cdev);
>
> stuser = stuser_create(stdev);
> - if (!stuser)
> + if (IS_ERR(stuser))
> return PTR_ERR(stuser);
>
> filp->private_data = stuser;
>
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH] switchtec: Fix an error handling Christophe JAILLET <christophe.jaillet@wanadoo.fr> - 2017-04-11 06:40 +0200
Re: [PATCH] switchtec: Fix an error handling Logan Gunthorpe <logang@deltatee.com> - 2017-04-11 06:40 +0200
Re: [PATCH] switchtec: Fix an error handling Bjorn Helgaas <helgaas@kernel.org> - 2017-04-12 19:30 +0200
Re: [PATCH] switchtec: Fix an error handling Logan Gunthorpe <logang@deltatee.com> - 2017-04-12 19:30 +0200
csiph-web