Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1620784

Re: Race to power off harming SATA SSDs

Show all headers | View raw

On Tue, 2017-04-11 at 08:52 +0900, Tejun Heo wrote:
[...]
> > Any comments?  Any clues on how to make the delay "smarter" to 
> > trigger only once during platform shutdown, but still trigger per
> > -device when doing per-device hotswapping ?
> 
> So, if this is actually an issue, sure, we can try to work around;
> however, can we first confirm that this has any other consequences
> than a SMART counter being bumped up?  I'm not sure how meaningful
> that is in itself.

Seconded; especially as the proposed patch is way too invasive: we run
single threaded on shutdown and making every disk wait 1s is going to
drive enterprises crazy.  I'm with Tejun: If the device replies GOOD to
SYNCHRONIZE CACHE, that means we're entitled to assume all written data
is safely on non-volatile media and any "essential housekeeping" can be
redone if the power goes away.

James

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Race to power off harming SATA SSDs Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2017-04-11 01:30 +0200
  Re: Race to power off harming SATA SSDs Bart Van Assche <Bart.VanAssche@sandisk.com> - 2017-04-11 01:40 +0200
    Re: Race to power off harming SATA SSDs Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2017-04-11 02:00 +0200
  sd: wait for slow devices on shutdown path Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2017-04-11 02:00 +0200
  Re: Race to power off harming SATA SSDs James Bottomley <James.Bottomley@HansenPartnership.com> - 2017-04-11 02:00 +0200
    Re: Race to power off harming SATA SSDs Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2017-04-11 04:10 +0200
  Re: Race to power off harming SATA SSDs Tejun Heo <tj@kernel.org> - 2017-04-11 02:00 +0200
    Re: Race to power off harming SATA SSDs Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2017-04-11 03:30 +0200
    Re: Race to power off harming SATA SSDs Martin Steigerwald <martin@lichtvoll.de> - 2017-04-11 12:50 +0200
      Re: Race to power off harming SATA SSDs Henrique de Moraes Holschuh <hmh@hmh.eng.br> - 2017-04-11 16:40 +0200
        Re: Race to power off harming SATA SSDs Martin Steigerwald <martin@lichtvoll.de> - 2017-04-12 09:50 +0200

csiph-web