Groups > linux.kernel > #1620030

Re: [PATCH -next v2] ARM: hisi: fix error return code in hip04_smp_init()

From	Wei Xu <xuwei5@hisilicon.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH -next v2] ARM: hisi: fix error return code in hip04_smp_init()
Date	2017-04-10 17:30 +0200
Message-ID	<tuJqq-2rm-25@gated-at.bofh.it> (permalink)
References	<t2tv3-36H-7@gated-at.bofh.it> <t7y14-1hp-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Yongjun,

On 2017/2/5 16:32, Wei Yongjun wrote:
> From: Wei Yongjun <weiyongjun1@huawei.com>
> 
> Fix to return error code -ENODEV from the of_find_compatible_node()
> error handling case instead of 0, as done elsewhere in this function.
> 
> Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>

Thanks!
Applied to the hisilicon soc tree.

Best Regards,
Wei

> ---
> v1 -> v2: fix file module
> ---
>  arch/arm/mach-hisi/platmcpm.c | 2 ++
>  1 file changed, 2 insertions(+)
> 
> diff --git a/arch/arm/mach-hisi/platmcpm.c b/arch/arm/mach-hisi/platmcpm.c
> index a6c1176..f0fff21 100644
> --- a/arch/arm/mach-hisi/platmcpm.c
> +++ b/arch/arm/mach-hisi/platmcpm.c
> @@ -279,6 +279,8 @@ static int __init hip04_smp_init(void)
>  					 &hip04_boot_method[0], 4);
>  	if (ret)
>  		goto err;
> +
> +	ret = -ENODEV;
>  	np_sctl = of_find_compatible_node(NULL, NULL, "hisilicon,sysctrl");
>  	if (!np_sctl)
>  		goto err;
> 
> 
>

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH -next v2] ARM: hisi: fix error return code in  hip04_smp_init() Wei Xu <xuwei5@hisilicon.com> - 2017-04-10 17:30 +0200

csiph-web