Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1619989
| From | Vitaly Kuznetsov <vkuznets@redhat.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH 2/7] x86/hyper-v: fast hypercall implementation |
| Date | 2017-04-10 16:50 +0200 |
| Message-ID | <tuINI-1Y2-3@gated-at.bofh.it> (permalink) |
| References | <ttAfw-6oW-11@gated-at.bofh.it> <ttAfw-6oW-9@gated-at.bofh.it> <ttI3o-3uy-17@gated-at.bofh.it> <tuDuG-788-13@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Vitaly Kuznetsov <vkuznets@redhat.com> writes:
> Jork Loeser <Jork.Loeser@microsoft.com> writes:
>
[snip]
>
>>> + }
>>> +#else
>>> + {
>>> + u32 hv_status_hi, hv_status_lo;
>>> +
>>> + __asm__ __volatile__ ("call *%6"
>>> + : "=d"(hv_status_hi),
>>> + "=a"(hv_status_lo) :
>>> + "d" (control.as_uint32_hi),
>>> + "a" (control.as_uint32_lo),
>>> + "c" ((u32)input1),
>>> + "b" ((u32)(input1 >> 32)),
>>> + "m" (hv_hypercall_pg)
>>> + : "cc");
>>> +
>>> + return hv_status_lo | ((u64)hv_status_hi << 32);
>>> + }
>>> +#endif
>> Please clobber ECX, EDI and ESI for x86. Clobber memory as well?
>
> ECX is already in listed in inputs (lower part of input1) so it's
> automatically clobbered. I'll add EDI and ESI to clobbers here, thanks!
Oh, I see what you mean - hypervisor is allowed to write to ecx too, we
need to pass it with '+'. Will do, thanks!
--
Vitaly
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH 2/7] x86/hyper-v: fast hypercall implementation Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-04-07 13:30 +0200
RE: [PATCH 2/7] x86/hyper-v: fast hypercall implementation Jork Loeser <Jork.Loeser@microsoft.com> - 2017-04-07 21:50 +0200
Re: [PATCH 2/7] x86/hyper-v: fast hypercall implementation Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-04-10 11:10 +0200
Re: [PATCH 2/7] x86/hyper-v: fast hypercall implementation Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-04-10 16:50 +0200
RE: [PATCH 2/7] x86/hyper-v: fast hypercall implementation Jork Loeser <Jork.Loeser@microsoft.com> - 2017-04-10 19:20 +0200
RE: [PATCH 2/7] x86/hyper-v: fast hypercall implementation KY Srinivasan <kys@microsoft.com> - 2017-04-08 17:20 +0200
Re: [PATCH 2/7] x86/hyper-v: fast hypercall implementation Vitaly Kuznetsov <vkuznets@redhat.com> - 2017-04-10 10:50 +0200
csiph-web