Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1619981

Re: [PATCH v2 02/22] asm-generic/io.h: add ioremap_nopost remap interface

Show all headers | View raw

On Thu, Apr 06, 2017 at 11:47:37AM +0100, Russell King - ARM Linux wrote:
> On Thu, Apr 06, 2017 at 11:26:36AM +0100, Lorenzo Pieralisi wrote:
> > On Wed, Apr 05, 2017 at 01:38:12PM +0100, Lorenzo Pieralisi wrote:
> > > eg: openrisc
> > > 
> > > >> include/asm-generic/io.h:922:9: error: implicit declaration of
> > > >> function 'ioremap_nocache' [-Werror=implicit-function-declaration]
> > >      return ioremap_nocache(offset, size);
> > 
> > Indeed, the static inline ioremap_nocache() fallback does not work
> > on all arches (whether I add the fallback in linux/io.h or
> > asm-generic/io.h is irrelevant), I bump into issues such as the one
> > reported above.
> 
> From what I can see:
> 
> (a) openrisc does define ioremap_nocache() in its asm/io.h
> (b) these do not:
> 
> $ grep -L 'ioremap_nocache' arch/*/include/asm/io.h
> arch/blackfin/include/asm/io.h
> arch/h8300/include/asm/io.h
> arch/m68k/include/asm/io.h
> arch/score/include/asm/io.h
> arch/sparc/include/asm/io.h
> 
> Out of those, blackfin, h8300 and score do not define it, whereas m68k
> and sparc do in other headers included by asm/io.h.  So it looks like
> we have three problem architectures that don't define an ioremap_nocache().
> 
> PCI on blackfin depends on BROKEN, so it's not selectable.  From what I
> can tell, h8300 and score do not allow PCI to be enabled (but maybe its
> buried elsewhere in their Kconfig files, I didn't check.)
> 
> So, I think a way around this is to make ioremap_nopost() conditional
> on PCI in linux/io.h for the time being - if its scope wants to be
> enlarged, then these three architectures would need to have either an
> ioremap_nopost() implementation added, or an ioremap_nocache()
> implementation.

Ok, I implemented asm-generic/ioremap-nopost.h, I do not think we need
a CONFIG_PCI guard (kbuild has not barfed at it, yet), given that
blackfin and h8300 are !MMU and score selects NO_IOMEM.

Patch below is all arches squashed into one commit, I probably have
to split it one per arch which will make this a 50-patch series in
total:

https://git.kernel.org/pub/scm/linux/kernel/git/lpieralisi/linux.git/commit/?h=pci/config-io-mappings-fix-v3&id=acc0be820c809101e02ab7cb170f802db53af934

If I hear no complaints I will split patch above one per arch and
repost the series shortly (even though I think I should make two series
out of it, one asm-generic/ioremap-nopost.h boilerplate and second
ARM/ARM64 implementation + PCI drivers).

Lorenzo

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v2 02/22] asm-generic/io.h: add ioremap_nopost remap  interface Bjorn Helgaas <helgaas@kernel.org> - 2017-03-28 03:50 +0200
  Re: [PATCH v2 02/22] asm-generic/io.h: add ioremap_nopost remap  interface Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-03-28 16:50 +0200
    Re: [PATCH v2 02/22] asm-generic/io.h: add ioremap_nopost remap  interface Bjorn Helgaas <helgaas@kernel.org> - 2017-03-30 18:50 +0200
    Re: [PATCH v2 02/22] asm-generic/io.h: add ioremap_nopost remap  interface Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-04-05 13:10 +0200
      Re: [PATCH v2 02/22] asm-generic/io.h: add ioremap_nopost remap  interface Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-04-05 14:50 +0200
        Re: [PATCH v2 02/22] asm-generic/io.h: add ioremap_nopost remap  interface Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-04-06 12:30 +0200
          Re: [PATCH v2 02/22] asm-generic/io.h: add ioremap_nopost remap  interface Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-04-06 12:50 +0200
            Re: [PATCH v2 02/22] asm-generic/io.h: add ioremap_nopost remap  interface Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-04-10 16:40 +0200
          Re: [PATCH v2 02/22] asm-generic/io.h: add ioremap_nopost remap  interface "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-04-06 13:00 +0200
            Re: [PATCH v2 02/22] asm-generic/io.h: add ioremap_nopost remap  interface Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-04-06 13:40 +0200
              Re: [PATCH v2 02/22] asm-generic/io.h: add ioremap_nopost remap  interface "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-04-06 14:00 +0200
                Re: [PATCH v2 02/22] asm-generic/io.h: add ioremap_nopost remap  interface Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-04-06 15:10 +0200
                Re: [PATCH v2 02/22] asm-generic/io.h: add ioremap_nopost remap  interface Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-04-06 18:30 +0200
                Re: [PATCH v2 02/22] asm-generic/io.h: add ioremap_nopost remap  interface Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-04-06 18:50 +0200
                Re: [PATCH v2 02/22] asm-generic/io.h: add ioremap_nopost remap  interface Lorenzo Pieralisi <lorenzo.pieralisi@arm.com> - 2017-04-06 19:20 +0200
                Re: [PATCH v2 02/22] asm-generic/io.h: add ioremap_nopost remap  interface Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-04-06 19:30 +0200
            Re: [PATCH v2 02/22] asm-generic/io.h: add ioremap_nopost remap  interface Russell King - ARM Linux <linux@armlinux.org.uk> - 2017-04-06 14:20 +0200
              Re: [PATCH v2 02/22] asm-generic/io.h: add ioremap_nopost remap  interface "Luis R. Rodriguez" <mcgrof@kernel.org> - 2017-04-06 14:30 +0200

csiph-web