Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1619903

Re: [PATCH 1/6] scsi: hisi_sas: workaround STP link SoC bug

Show all headers | View raw

On Mon, Apr 10, 2017 at 09:21:56PM +0800, John Garry wrote:
> From: Xiaofei Tan <tanxiaofei@huawei.com>
> 
> After resetting the controller, the process of scanning SATA disks
> attached to an expander may fail occasionally. The issue is that
> the controller can't close the STP link created by target if the
> max link time is 0.
> 
> To workaround this issue, we reject STP link after resetting the
> controller, and change the corresponding PHY to accept STP link
> only after receiving data.
> 
> We do this check in cq interrupt handler. In order not to reduce
> efficiency, we use an variable to control whether we should check
> and change PHY to accept STP link.
> 
> The function phys_reject_stp_links_v2_hw() should be called after
> resetting the controller.
> 
> The solution of another SoC bug "SATA IO timeout", that also uses
> the same register to control STP link, is not effective before
> the PHY accepts STP link.
> 
> Signed-off-by: Xiaofei Tan <tanxiaofei@huawei.com>
> Signed-off-by: John Garry <john.garry@huawei.com>
> ---

Looks good,
Reviewed-by: Johannes Thumshirn <jthumshirn@suse.de>

-- 
Johannes Thumshirn                                          Storage
jthumshirn@suse.de                                +49 911 74053 689
SUSE LINUX GmbH, Maxfeldstr. 5, 90409 Nürnberg
GF: Felix Imendörffer, Jane Smithard, Graham Norton
HRB 21284 (AG Nürnberg)
Key fingerprint = EC38 9CAB C2C4 F25D 8600 D0D0 0393 969D 2D76 0850

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/6] hisi_sas: v2 hw SoC bug workarounds John Garry <john.garry@huawei.com> - 2017-04-10 15:00 +0200
  [PATCH 4/6] scsi: hisi_sas: add v2 hw internal abort timeout workaround John Garry <john.garry@huawei.com> - 2017-04-10 15:00 +0200
  [PATCH 1/6] scsi: hisi_sas: workaround STP link SoC bug John Garry <john.garry@huawei.com> - 2017-04-10 15:00 +0200
    Re: [PATCH 1/6] scsi: hisi_sas: workaround STP link SoC bug Johannes Thumshirn <jthumshirn@suse.de> - 2017-04-10 15:20 +0200
  [PATCH 3/6] scsi: hisi_sas: workaround SoC about abort timeout bug John Garry <john.garry@huawei.com> - 2017-04-10 15:00 +0200
  [PATCH 2/6] scsi: hisi_sas: workaround a SoC SATA IO processing bug John Garry <john.garry@huawei.com> - 2017-04-10 15:00 +0200
    Re: [PATCH 2/6] scsi: hisi_sas: workaround a SoC SATA IO processing  bug Johannes Thumshirn <jthumshirn@suse.de> - 2017-04-10 16:10 +0200
  Re: [PATCH 0/6] hisi_sas: v2 hw SoC bug workarounds "Martin K. Petersen" <martin.petersen@oracle.com> - 2017-04-12 04:10 +0200

csiph-web