Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1619949
| From | Oleksandr Andrushchenko <andr2000@gmail.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [Xen-devel] [PATCH 1/2] xen, input: add xen-kbdfront module parameter for setting resolution |
| Date | 2017-04-10 15:50 +0200 |
| Message-ID | <tuHRE-1kI-17@gated-at.bofh.it> (permalink) |
| References | <tnvLz-6rG-7@gated-at.bofh.it> <tnvLz-6rG-17@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
Hi, Juergen!
On 03/21/2017 07:19 PM, Juergen Gross wrote:
> Add a parameter for setting the resolution of xen-kbdfront in order to
> be able to cope with a (virtual) frame buffer of arbitrary resolution.
>
> Signed-off-by: Juergen Gross <jgross@suse.com>
> ---
> drivers/input/misc/xen-kbdfront.c | 10 ++++++++--
> 1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/input/misc/xen-kbdfront.c b/drivers/input/misc/xen-kbdfront.c
> index 3900875..2df5678 100644
> --- a/drivers/input/misc/xen-kbdfront.c
> +++ b/drivers/input/misc/xen-kbdfront.c
> @@ -41,6 +41,12 @@ struct xenkbd_info {
> char phys[32];
> };
>
> +enum { KPARAM_WIDTH, KPARAM_HEIGHT, KPARAM_CNT };
> +static int size[KPARAM_CNT] = { XENFB_WIDTH, XENFB_HEIGHT };
> +module_param_array(size, int, NULL, 0444);
is this by intention that you use 0444 here?
It means read-only, thus one cannot change these,
so what is the point of the module parameters then?
> +MODULE_PARM_DESC(size,
> + "Pointing device width, height in pixels (default 800,600)");
> +
> static int xenkbd_remove(struct xenbus_device *);
> static int xenkbd_connect_backend(struct xenbus_device *, struct xenkbd_info *);
> static void xenkbd_disconnect_backend(struct xenkbd_info *);
> @@ -174,8 +180,8 @@ static int xenkbd_probe(struct xenbus_device *dev,
>
> if (abs) {
> __set_bit(EV_ABS, ptr->evbit);
> - input_set_abs_params(ptr, ABS_X, 0, XENFB_WIDTH, 0, 0);
> - input_set_abs_params(ptr, ABS_Y, 0, XENFB_HEIGHT, 0, 0);
> + input_set_abs_params(ptr, ABS_X, 0, size[KPARAM_WIDTH], 0, 0);
> + input_set_abs_params(ptr, ABS_Y, 0, size[KPARAM_HEIGHT], 0, 0);
> } else {
> input_set_capability(ptr, EV_REL, REL_X);
> input_set_capability(ptr, EV_REL, REL_Y);
Thank you,
Oleksandr
Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread
Re: [Xen-devel] [PATCH 1/2] xen, input: add xen-kbdfront module parameter for setting resolution Oleksandr Andrushchenko <andr2000@gmail.com> - 2017-04-10 15:50 +0200
Re: [Xen-devel] [PATCH 1/2] xen, input: add xen-kbdfront module parameter for setting resolution Juergen Gross <jgross@suse.com> - 2017-04-10 16:00 +0200
Re: [Xen-devel] [PATCH 1/2] xen, input: add xen-kbdfront module parameter for setting resolution Oleksandr Andrushchenko <andr2000@gmail.com> - 2017-04-10 16:10 +0200
Re: [Xen-devel] [PATCH 1/2] xen, input: add xen-kbdfront module parameter for setting resolution Oleksandr Andrushchenko <andr2000@gmail.com> - 2017-04-10 16:20 +0200
Re: [Xen-devel] [PATCH 1/2] xen, input: add xen-kbdfront module parameter for setting resolution Juergen Gross <jgross@suse.com> - 2017-04-11 11:00 +0200
Re: [Xen-devel] [PATCH 1/2] xen, input: add xen-kbdfront module parameter for setting resolution Juergen Gross <jgross@suse.com> - 2017-04-10 16:20 +0200
csiph-web