Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1619852

Re: [PATCH] net: netfilter: ipvs: Replace explicit NULL comparison

Show all headers | View raw

Arushi,

On Sun, Apr 09, 2017 at 06:21:51AM +0800, kbuild test robot wrote:
> Hi Arushi,
> 
> [auto build test WARNING on ipvs-next/master]
> [also build test WARNING on v4.11-rc5 next-20170407]
> [if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
> 
> url:    https://github.com/0day-ci/linux/commits/Arushi-Singhal/net-netfilter-ipvs-Replace-explicit-NULL-comparison/20170409-044710
> base:   https://git.kernel.org/pub/scm/linux/kernel/git/horms/ipvs-next.git master
> config: i386-randconfig-x002-201715 (attached as .config)
> compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
> reproduce:
>         # save the attached .config to linux build tree
>         make ARCH=i386 
> 
> All warnings (new ones prefixed by >>):
> 
>    net/netfilter/ipvs/ip_vs_proto.c: In function 'ip_vs_protocol_net_cleanup':
> >> net/netfilter/ipvs/ip_vs_proto.c:350:3: warning: suggest parentheses around assignment used as truth value [-Wparentheses]
>       while (pd = ipvs->proto_data_table[i])
>       ^~~~~

This is bad, you have to be more careful in what you do. This is not a
speed coding contest.

Showing careful patchset handling, even if you submit less of them, is
way more prefered in my opinion.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: netfilter: ipvs: Replace explicit NULL comparison Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-04-08 19:20 +0200
  Re: [PATCH] net: netfilter: ipvs: Replace explicit NULL comparison kbuild test robot <lkp@intel.com> - 2017-04-09 00:30 +0200
    Re: [PATCH] net: netfilter: ipvs: Replace explicit NULL comparison Pablo Neira Ayuso <pablo@netfilter.org> - 2017-04-10 14:00 +0200

csiph-web