Groups > linux.kernel > #1619731

[PATCH] bug: Avoid setting BUGFLAG_WARNING twice

From	Peter Zijlstra <peterz@infradead.org>
Newsgroups	linux.kernel
Subject	[PATCH] bug: Avoid setting BUGFLAG_WARNING twice
Date	2017-04-10 10:50 +0200
Message-ID	<tuDbk-6MH-17@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Dan reported that his static checking complains about BUGFLAG_WARNING
being set on both sides of the bitwise-or, it figures that that might've
been an unintentional mistake.

Since there are no architectures that implement __WARN_TAINT() (I
converted them all to implement __WARN_FLAGS()), and all __WARN_FLAGS()
implementations already set BUGFLAG_WARNING, we can remove the bit from
BUGFLAG_TAINT() and make Dan's checker happy.

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
 include/asm-generic/bug.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/include/asm-generic/bug.h b/include/asm-generic/bug.h
index 5fe9f39cec44..d6f4aed479a1 100644
--- a/include/asm-generic/bug.h
+++ b/include/asm-generic/bug.h
@@ -7,7 +7,7 @@
 #define BUGFLAG_WARNING		(1 << 0)
 #define BUGFLAG_ONCE		(1 << 1)
 #define BUGFLAG_DONE		(1 << 2)
-#define BUGFLAG_TAINT(taint)	(BUGFLAG_WARNING | ((taint) << 8))
+#define BUGFLAG_TAINT(taint)	((taint) << 8)
 #define BUG_GET_TAINT(bug)	((bug)->flags >> 8)
 #endif

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH] bug: Avoid setting BUGFLAG_WARNING twice Peter Zijlstra <peterz@infradead.org> - 2017-04-10 10:50 +0200

csiph-web