Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1619753

Re: [PATCH 1/2] s390/perf: fix perf annotate error -95 (4.10 regression)

Show all headers | View raw

On 04/07/2017 05:23 PM, Arnaldo Carvalho de Melo wrote:
> Em Thu, Apr 06, 2017 at 09:51:51AM +0200, Christian Borntraeger escreveu:
>> since 4.10 perf annotate exits on s390 with an "unknown error -95".
>> Turns out that commit 786c1b51844d ("perf annotate: Start supporting
>> cross arch annotation") added a hard requirement for architecture
> 
> Argh, that was unfortunate, I'll apply your patches and try to remove
> that restriction, using the defaults previously in place :-\

Is there a chance to get this fix into 4.11? (the 2nd patch can certainly wait
for the next merge window)

> 
> thanks,
> 
> - Arnaldo
> 
> 
>> support when objdump is used but only provided x86 and arm
>> support. Meanwhile power was added so lets add s390 as well.
>>
>> While at it make sure to implement the branch and jump types.
>>
>> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
>> Fixes: 786c1b51844 "perf annotate: Start supporting cross arch annotation"
>> Cc: Arnaldo Carvalho de Melo <acme@redhat.com>
>> ---
>>  tools/perf/util/annotate.c | 6 ++++++
>>  1 file changed, 6 insertions(+)
>>
>> diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c
>> index 273f21f..7aa5722 100644
>> --- a/tools/perf/util/annotate.c
>> +++ b/tools/perf/util/annotate.c
>> @@ -130,6 +130,12 @@ static struct arch architectures[] = {
>>  		.name = "powerpc",
>>  		.init = powerpc__annotate_init,
>>  	},
>> +	{
>> +		.name = "s390",
>> +		.objdump =  {
>> +			.comment_char = '#',
>> +		},
>> +	},
>>  };
>>  
>>  static void ins__delete(struct ins_operands *ops)
>> -- 
>> 2.7.4
> 

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 0/2] perf/s390: fix (and enhance) perf annotate Christian Borntraeger <borntraeger@de.ibm.com> - 2017-04-06 10:00 +0200
  [PATCH 2/2] perf/s390: implement jump types for perf annotate Christian Borntraeger <borntraeger@de.ibm.com> - 2017-04-06 10:00 +0200
    [tip:perf/core] perf annotate s390: Implement jump types for perf  annotate tip-bot for Christian Borntraeger <tipbot@zytor.com> - 2017-04-12 07:50 +0200
  [PATCH 1/2] s390/perf: fix perf annotate error -95 (4.10 regression) Christian Borntraeger <borntraeger@de.ibm.com> - 2017-04-06 10:00 +0200
    Re: [PATCH 1/2] s390/perf: fix perf annotate error -95 (4.10  regression) Arnaldo Carvalho de Melo <acme@redhat.com> - 2017-04-07 17:30 +0200
      Re: [PATCH 1/2] s390/perf: fix perf annotate error -95 (4.10  regression) Christian Borntraeger <borntraeger@de.ibm.com> - 2017-04-10 11:30 +0200
    [tip:perf/urgent] perf annotate s390: Fix perf annotate error -95  (4.10 regression) tip-bot for Christian Borntraeger <tipbot@zytor.com> - 2017-04-11 21:50 +0200
    [tip:perf/core] perf annotate s390: Fix perf annotate error -95  (4.10 regression) tip-bot for Christian Borntraeger <tipbot@zytor.com> - 2017-04-12 07:50 +0200

csiph-web