Groups > linux.kernel > #1619664

Re: [PATCH] PM / OPP: Use - instead of @ for DT entries

From	Krzysztof Kozlowski <krzk@kernel.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] PM / OPP: Use - instead of @ for DT entries
Date	2017-04-10 08:50 +0200
Message-ID	<tuBjc-5Ba-7@gated-at.bofh.it> (permalink)
References	<tuzU5-4PN-5@gated-at.bofh.it> <tuAZQ-5uN-15@gated-at.bofh.it> <tuB9v-5xS-5@gated-at.bofh.it> <tuB9w-5xS-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Mon, Apr 10, 2017 at 8:32 AM, Viresh Kumar <viresh.kumar@linaro.org> wrote:
> On 10-04-17, 15:30, Masahiro Yamada wrote:
>> 2017-04-10 15:22 GMT+09:00 Viresh Kumar <viresh.kumar@linaro.org>:
>> > On 10-04-17, 10:46, Viresh Kumar wrote:
>> >> Compiling the DT file with W=1, DTC warns like follows:
>> >>
>> >> Warning (unit_address_vs_reg): Node /opp_table0/opp@1000000000 has a
>> >> unit name, but no reg property
>> >>
>> >> Fix this by replacing '@' with '-' as the OPP nodes will never have a
>> >> "reg" property.
>> >>
>> >> Reported-by: Masahiro Yamada <yamada.masahiro@socionext.com>
>> >> Signed-off-by: Viresh Kumar <viresh.kumar@linaro.org>
>> >
>> > + Reported-by: Krzysztof Kozlowski <krzk@kernel.org>
>> >
>> > --
>> > viresh
>>
>>
>> Given that this had already been reported one year before,
>> the reported-by credit should be given to Krzysztof.
>>
>> Please drop my Reported-by.
>
> I don't think we need to drop any of you. We can very well keep both
> :)

Yes, keeping both make most sense, I think.

Anyway, I found now the original report thread of Masahiro and I see
Mark's response about using '-'. In that case I am fine with this. I
would prefer to take only the exynos part (separated to ARMv7 and
ARMv8) through my tree but I already sent a pull request so I am fine
with this going directly to arm-soc.

I think you need to update also:
Documentation/devicetree/bindings/cpufreq/ti-cpufreq.txt
With that change:
Reviewed-by: Krzysztof Kozlowski <krzk@kernel.org>
(and implied acked-by)

Best regards,
Krzysztof

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH] PM / OPP: Use - instead of @ for DT entries Viresh Kumar <viresh.kumar@linaro.org> - 2017-04-10 08:30 +0200
  Re: [PATCH] PM / OPP: Use - instead of @ for DT entries Masahiro Yamada <yamada.masahiro@socionext.com> - 2017-04-10 08:40 +0200
    Re: [PATCH] PM / OPP: Use - instead of @ for DT entries Viresh Kumar <viresh.kumar@linaro.org> - 2017-04-10 08:40 +0200
      Re: [PATCH] PM / OPP: Use - instead of @ for DT entries Viresh Kumar <viresh.kumar@linaro.org> - 2017-04-10 08:50 +0200
      Re: [PATCH] PM / OPP: Use - instead of @ for DT entries Krzysztof Kozlowski <krzk@kernel.org> - 2017-04-10 08:50 +0200

csiph-web