Groups > linux.kernel > #1619672

Re: [PATCH] phy: qcom-qmp: Add dependency on COMMON_CLK

From	Vivek Gautam <vivek.gautam@codeaurora.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] phy: qcom-qmp: Add dependency on COMMON_CLK
Date	2017-04-10 09:10 +0200
Message-ID	<tuBCx-5Wv-5@gated-at.bofh.it> (permalink)
References	<ttm2S-5DN-19@gated-at.bofh.it> <ttm2S-5DN-17@gated-at.bofh.it> <tuA3L-4Ux-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On 2017-04-10 10:52, Kishon Vijay Abraham I wrote:
> On Friday 07 April 2017 01:37 AM, Vivek Gautam wrote:
>> The driver uses clock provider interface, and therefore
>> it fails to build when enabled for COMPILE_TEST, since
>> COMMON_CLK is not enabled at that time.
>> So, make PHY_QCOM_QMP depend on COMMON_CLK as well.
>> 
>> Cc: Fengguang Wu <fengguang.wu@intel.com>
>> Cc: Kishon Vijay Abraham I <kishon@ti.com>
>> Signed-off-by: Vivek Gautam <vivek.gautam@codeaurora.org>
>> ---
>> 
>> Hi Kishon,
>> 
>> This patch is fixing the build failures for architectures
>> such as, tile, and ia64, that don't enable COMMON_CLK by default.
>> You can either squash this into the qmp phy driver patch,
>> or put it as a separate patch with 'Fix' tag.
>> Let me know if you want me to add a 'fix' tag with a reference
>> to the commit ID.
> 
> I squashed it with your earlier patch and pushed.

Thanks Kishon.

Regards
Vivek

> 
> Thanks
> Kishon
> 
>> 
>> Regards
>> Vivek
>> 
>>  drivers/phy/Kconfig | 2 +-
>>  1 file changed, 1 insertion(+), 1 deletion(-)
>> 
>> diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig
>> index bb8140355608..8550d3dc0b71 100644
>> --- a/drivers/phy/Kconfig
>> +++ b/drivers/phy/Kconfig
>> @@ -441,7 +441,7 @@ config PHY_STIH407_USB
>> 
>>  config PHY_QCOM_QMP
>>  	tristate "Qualcomm QMP PHY Driver"
>> -	depends on OF && (ARCH_QCOM || COMPILE_TEST)
>> +	depends on OF && COMMON_CLK && (ARCH_QCOM || COMPILE_TEST)
>>  	select GENERIC_PHY
>>  	help
>>  	  Enable this to support the QMP PHY transceiver that is used
>> 
> --
> To unsubscribe from this list: send the line "unsubscribe 
> linux-arm-msm" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] phy: qcom-qmp: Add dependency on COMMON_CLK Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-04-06 22:20 +0200
  Re: [PATCH] phy: qcom-qmp: Add dependency on COMMON_CLK Kishon Vijay Abraham I <kishon@ti.com> - 2017-04-10 07:30 +0200
    Re: [PATCH] phy: qcom-qmp: Add dependency on COMMON_CLK Vivek Gautam <vivek.gautam@codeaurora.org> - 2017-04-10 09:10 +0200

csiph-web