Groups > linux.kernel > #1619426

[PATCH 11/12] [media] wl128x: use setup_timer

Path	csiph.com!goblin2!goblin.stu.neva.ru!aioe.org!bofh.it!news.nic.it!robomod
From	Geliang Tang <geliangtang@gmail.com>
Newsgroups	linux.kernel
Subject	[PATCH 11/12] [media] wl128x: use setup_timer
Date	Sun, 09 Apr 2017 03:40:02 +0200
Message-ID	<tu9ZE-4FS-19@gated-at.bofh.it> (permalink)
References	<tu9ZD-4FS-3@gated-at.bofh.it>
X-Original-To	Mauro Carvalho Chehab <mchehab@kernel.org>, Geert Uytterhoeven <geert@linux-m68k.org>
Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=BLNKQD+osLS0izElgAUrfZ4pN6ZYjlogf7+SUuIzxHU=; b=RNDboKkgWDswSZL/QEb7qRCd8pXAUgU4/oU3Pf5Ggl02H2li/GiEavMJNT0d8aAfkc d3Tlfc8/RjTz1TC5UUMReLBPp/w7XBkYdVNBQu2w1vjbj05Bxc2Vx+JyOWTi93ZbVcpq R/CIsFNdoFJPYDCUDglkijzt/WMqlWyHDvqkhdQmOoS0t7WTGeSsuDUMK/bEj/SZevfP 7Gqc+S0VDYpkoxyw3bQKQn//Fh1H20MLSkXoMNnLa6swvpJ+cfPnbpE2LA3Cq1ZKCM4V sBNYddd2nPigISuwPgmc0BZ0J5ecV6qV0pTr9cQhKztjz1TqnlrftGJ/4+ofJ3oZ+o2M vjAQ==
X-Google-Dkim-Signature	v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=BLNKQD+osLS0izElgAUrfZ4pN6ZYjlogf7+SUuIzxHU=; b=oAe/gEs1wyMdYnCA0HemNohOI3J8yUKNRzlp7qvCzwGoFzZV9lmAywQTJ+o0XSofq4 e40W59rZBeQi2c5PdBChrtRhgnWXvof4VKFln6SnQwoEUKwOEm1zMkR2s9DmWU9DpXV/ l/FGHAyY4fZVoyDyI+jE1BC4JmSMIFnKkB6URAkVcZf0srC1HSeFOxfsj9aPj/L9HEya bVcQbku2QTVYQQNViGXBLxwvMELbo4uMFlLInxv/klG+g3rpEU1HJrwYUrGNxjuynhY/ o8FskthqVdk1ioeaCNWKVK4eylUwWKKo0EGxQUSSaQZ3GI6pU1ySIgCjsigSW6+3SU3O 5t6w==
X-Gm-Message-State	AFeK/H1G+fNjgRnu4MFbEBSdiBV8bWbtPBeHVlBa2FAQWRlPsyEszXMI55cs5U8lmVEuQg==
X-Received	by 10.84.128.47 with SMTP id 44mr23350327pla.35.1491701720751; Sat, 08 Apr 2017 18:35:20 -0700 (PDT)
X-Mailer	git-send-email 2.9.3
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	25
Organization	linux.* mail to news gateway
X-Original-Cc	Geliang Tang <geliangtang@gmail.com>, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date	Sun, 9 Apr 2017 09:34:07 +0800
X-Original-Message-ID	<51e22bc38526ec47c01030147761a873fac3e894.1490953290.git.geliangtang@gmail.com>
X-Original-References	<77c0fb26d214e023a99afc948c71d6edd9284205.1490953290.git.geliangtang@gmail.com>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1619426

Show key headers only | View raw

Use setup_timer() instead of init_timer() to simplify the code.

Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
 drivers/media/radio/wl128x/fmdrv_common.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/media/radio/wl128x/fmdrv_common.c b/drivers/media/radio/wl128x/fmdrv_common.c
index 74a1b3e..588e2d6 100644
--- a/drivers/media/radio/wl128x/fmdrv_common.c
+++ b/drivers/media/radio/wl128x/fmdrv_common.c
@@ -1550,9 +1550,8 @@ int fmc_prepare(struct fmdev *fmdev)
 	atomic_set(&fmdev->tx_cnt, 1);
 	fmdev->resp_comp = NULL;
 
-	init_timer(&fmdev->irq_info.timer);
-	fmdev->irq_info.timer.function = &int_timeout_handler;
-	fmdev->irq_info.timer.data = (unsigned long)fmdev;
+	setup_timer(&fmdev->irq_info.timer, &int_timeout_handler,
+		    (unsigned long)fmdev);
 	/*TODO: add FM_STIC_EVENT later */
 	fmdev->irq_info.mask = FM_MAL_EVENT;
 
-- 
2.9.3

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 01/12] [media] saa7134: use setup_timer Geliang Tang <geliangtang@gmail.com> - 2017-04-09 03:40 +0200
  [PATCH 02/12] [media] saa7146: use setup_timer Geliang Tang <geliangtang@gmail.com> - 2017-04-09 03:40 +0200
  [PATCH 04/12] [media] cx18: use setup_timer Geliang Tang <geliangtang@gmail.com> - 2017-04-09 03:40 +0200
  [PATCH 11/12] [media] wl128x: use setup_timer Geliang Tang <geliangtang@gmail.com> - 2017-04-09 03:40 +0200

csiph-web