Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1619417

[PATCH 09/12] [media] s5p-mfc: use setup_timer

Path csiph.com!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From Geliang Tang <geliangtang@gmail.com>
Newsgroups linux.kernel
Subject [PATCH 09/12] [media] s5p-mfc: use setup_timer
Date Sun, 09 Apr 2017 03:40:02 +0200
Message-ID <tu9ZE-4FS-11@gated-at.bofh.it> (permalink)
References <tu9ZD-4FS-3@gated-at.bofh.it>
Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references :in-reply-to:references; bh=r6gmuG6f6XeSEfpnHOHLktmSpyw5senZ7FgEdV9URWg=; b=GJcGIMvVY6+kE13OIL3ZxGDzLPqBBjF7momkLxVk1O6/hwco1+UBQoH4T2gn1SfL/1 uPk6Tghm7xK6/fy1pTOtXcuWhJoUc5i041TZ3egVOhNsLapqY4gdALq3uXd2p0lsDX8f ezyPaAwEos1un7pHQY3p32OGE6xT+0AG4yECyPEI2W+6leNW8c1mjQtEAzD3VRsLr4k8 MxGZZhswRuscj75t8T5/xRjc4ac5g92FmVPw9sa3w438mC1NDOhCCT4yHmYIVxzuP0fx 7yHAJrIk5so+5aieA/8AgBMEYhTGJ7QzL9k4PhI4Qegk0yD1eUtHlHaFMwIv+QkQiFNy dONg==
X-Google-Dkim-Signature v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:in-reply-to:references; bh=r6gmuG6f6XeSEfpnHOHLktmSpyw5senZ7FgEdV9URWg=; b=qgxIPPQD8b47/ifFsS/2I3Hge+M03NCG1nFpGry/2rrsNIzPtbDQStG/qT9Ob3uLZs SUZUXP1HGOLZ+7ufmrZoDd4F88JEADNPpKe5c7RW9n37Ug0fRmqK7ocizi38r3zFeKfJ mLpatyv7hWwJVEyZ3rr5Nzh42H/5pxjKT/E5NmeXr4qsgHaqCzVjeyEnQbQWtM3cJEcz AESw6pWXgro9Dz2gMYNXXfMmtvgbUUdJYn5PLUqw2+ZPNPGtiodxOfeKbeW1yezEUq5X lTOx1FUxdW9+khTz6OIJ5AUCsSQf+qQm1t9dX5rimpAzFV3ah96rEeWU3FbZvrZVw9T6 4QMA==
X-Gm-Message-State AFeK/H2q+Qom/BL1h3P26YMBFkcFN+WURUJ+M6RpcBkGAKOQkgMQ3SVnWlTKDng69qMp2g==
X-Received by 10.98.78.8 with SMTP id c8mr46966584pfb.155.1491701703681; Sat, 08 Apr 2017 18:35:03 -0700 (PDT)
X-Mailer git-send-email 2.9.3
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 25
Organization linux.* mail to news gateway
X-Original-Cc Geliang Tang <geliangtang@gmail.com>, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Sun, 9 Apr 2017 09:34:05 +0800
X-Original-Message-ID <f35bda17a884852135983ab4128976b9c220a768.1490953290.git.geliangtang@gmail.com>
X-Original-References <77c0fb26d214e023a99afc948c71d6edd9284205.1490953290.git.geliangtang@gmail.com>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1619417

Show key headers only | View raw


Use setup_timer() instead of init_timer() to simplify the code.

Signed-off-by: Geliang Tang <geliangtang@gmail.com>
---
 drivers/media/platform/s5p-mfc/s5p_mfc.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c
index bb0a588..2c363aa 100644
--- a/drivers/media/platform/s5p-mfc/s5p_mfc.c
+++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c
@@ -1266,9 +1266,8 @@ static int s5p_mfc_probe(struct platform_device *pdev)
 	dev->hw_lock = 0;
 	INIT_WORK(&dev->watchdog_work, s5p_mfc_watchdog_worker);
 	atomic_set(&dev->watchdog_cnt, 0);
-	init_timer(&dev->watchdog_timer);
-	dev->watchdog_timer.data = (unsigned long)dev;
-	dev->watchdog_timer.function = s5p_mfc_watchdog;
+	setup_timer(&dev->watchdog_timer, s5p_mfc_watchdog,
+		    (unsigned long)dev);
 
 	/* Initialize HW ops and commands based on MFC version */
 	s5p_mfc_init_hw_ops(dev);
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread


Thread

[PATCH 09/12] [media] s5p-mfc: use setup_timer Geliang Tang <geliangtang@gmail.com> - 2017-04-09 03:40 +0200
  Re: [PATCH 09/12] [media] s5p-mfc: use setup_timer Sylwester Nawrocki <s.nawrocki@samsung.com> - 2017-04-10 10:40 +0200

csiph-web