Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1619382

Re: [PATCH] net: netfilter: Replace explicit NULL comparisons

From Pablo Neira Ayuso <pablo@netfilter.org>
Newsgroups linux.kernel
Subject Re: [PATCH] net: netfilter: Replace explicit NULL comparisons
Date 2017-04-08 22:20 +0200
Message-ID <tu4ZX-1w6-5@gated-at.bofh.it> (permalink)
References <tu2lr-8cD-1@gated-at.bofh.it> <tu3hv-oq-1@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Sat, Apr 08, 2017 at 08:21:56PM +0200, Jan Engelhardt wrote:
> On Saturday 2017-04-08 19:21, Arushi Singhal wrote:
> 
> >Replace explicit NULL comparison with ! operator to simplify code.
> 
> I still wouldn't do this, for the same reason as before. Comparing to 
> NULL explicitly more or less gave an extra guarantee that the other 
> operand was also a pointer.

Arushi, where does it say in the coding style that this is prefered?

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH] net: netfilter: Replace explicit NULL comparisons Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-04-08 19:30 +0200
  Re: [PATCH] net: netfilter: Replace explicit NULL comparisons Jan Engelhardt <jengelh@inai.de> - 2017-04-08 20:30 +0200
    Re: [PATCH] net: netfilter: Replace explicit NULL comparisons Pablo Neira Ayuso <pablo@netfilter.org> - 2017-04-08 22:20 +0200
      Re: [PATCH] net: netfilter: Replace explicit NULL comparisons Jan Engelhardt <jengelh@inai.de> - 2017-04-09 10:30 +0200
        Re: [PATCH] net: netfilter: Replace explicit NULL comparisons Liping Zhang <zlpnobody@gmail.com> - 2017-04-09 11:40 +0200
      Re: [PATCH] net: netfilter: Replace explicit NULL comparisons Pablo Neira Ayuso <pablo@netfilter.org> - 2017-04-10 14:00 +0200

csiph-web