Groups > linux.kernel > #1619370

Re: `pci_apply_final_quirks()` taking half a second

From	Bjorn Helgaas <helgaas@kernel.org>
Newsgroups	linux.kernel
Subject	Re: `pci_apply_final_quirks()` taking half a second
Date	2017-04-08 21:10 +0200
Message-ID	<tu3Ud-SQ-3@gated-at.bofh.it> (permalink)
References	<ttJiN-4zq-11@gated-at.bofh.it> <tu0MF-78Z-5@gated-at.bofh.it> <tu225-85S-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Apr 08, 2017 at 07:00:19PM +0200, David Woodhouse wrote:
> ...
> I note it's also reading PCI_CACHE_LINE_SIZE From config space for each
> device in pci_apply_final_quirks(). How long does that take?

I don't know, but it's pointless on modern PCIe systems where the
Cache Line Size has no effect.  It'd be really nice if somebody
cleaned that up and got rid of the read itself and the useless
messages.

Bjorn

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

`pci_apply_final_quirks()` taking half a second Paul Menzel <pmenzel@molgen.mpg.de> - 2017-04-07 23:10 +0200
  Re: `pci_apply_final_quirks()` taking half a second Bjorn Helgaas <helgaas@kernel.org> - 2017-04-08 17:50 +0200
    Re: `pci_apply_final_quirks()` taking half a second David Woodhouse <dwmw2@infradead.org> - 2017-04-08 19:10 +0200
      Re: `pci_apply_final_quirks()` taking half a second Bjorn Helgaas <helgaas@kernel.org> - 2017-04-08 21:10 +0200

csiph-web