Groups > linux.kernel > #1619361

Re: [PATCH] ibmveth: Support to enable LSO/CSO for Trunk VEA.

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ibmveth: Support to enable LSO/CSO for Trunk VEA.
Date	2017-04-08 20:50 +0200
Message-ID	<tu3AR-v6-3@gated-at.bofh.it> (permalink)
References	<ttyQr-5pF-25@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Sivakumar Krishnasamy <ksiva@linux.vnet.ibm.com>
Date: Fri,  7 Apr 2017 05:57:59 -0400

> Enable largesend and checksum offload for ibmveth configured in trunk mode.
> Added support to SKB frag_list in TX path by skb_linearize'ing such SKBs.
> 
> Signed-off-by: Sivakumar Krishnasamy <ksiva@linux.vnet.ibm.com>

Why is linearization necessary?

It would seem that the gains you get from GRO are nullified by
linearizing the SKB and thus copying all the data around and
allocating buffers.

Finally, all of that new checksumming stuff looks extremely
suspicious.  You have to explain why that is happening and why it
isn't because this driver is doing something incorrectly.

Thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] ibmveth: Support to enable LSO/CSO for Trunk VEA. Sivakumar Krishnasamy <ksiva@linux.vnet.ibm.com> - 2017-04-07 12:00 +0200
  Re: [PATCH] ibmveth: Support to enable LSO/CSO for Trunk VEA. David Miller <davem@davemloft.net> - 2017-04-08 20:50 +0200

csiph-web