Groups > linux.kernel > #1619301

Re: [PATCH][-next] nfp: don't dereference a null nn->eth_port to print a warning

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH][-next] nfp: don't dereference a null nn->eth_port to print a warning
Date	2017-04-08 17:20 +0200
Message-ID	<tu0jD-6UX-9@gated-at.bofh.it> (permalink)
References	<ttfb5-cf-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Colin King <colin.king@canonical.com>
Date: Thu,  6 Apr 2017 13:54:35 +0100

> From: Colin Ian King <colin.king@canonical.com>
> 
> On the case where nn->eth_port is null the warning message
> is printing the port by dereferencing this null pointer.
> Remove the deference to avoid a crash when printing the
> warning message.
> 
> Detected by CoverityScan, CID#1426198 ("Dereference after null check")
> 
> Fixes: ce22f5a2cbe3c627 ("nfp: separate high level and low level NSP headers")
> Signed-off-by: Colin Ian King <colin.king@canonical.com>

Applied, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH][-next] nfp: don't dereference a null nn->eth_port to print a warning Colin King <colin.king@canonical.com> - 2017-04-06 15:00 +0200
  Re: [PATCH][-next] nfp: don't dereference a null nn->eth_port to  print a warning Jakub Kicinski <jakub.kicinski@netronome.com> - 2017-04-07 01:20 +0200
  Re: [PATCH][-next] nfp: don't dereference a null nn->eth_port to  print a warning David Miller <davem@davemloft.net> - 2017-04-08 17:20 +0200

csiph-web