Re: [PATCH v4 0/3] Add Mediatek CIRQ interrupt controller

From	Youlin Pei <youlin.pei@mediatek.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v4 0/3] Add Mediatek CIRQ interrupt controller
Date	2017-04-07 12:00 +0200
Message-ID	<ttyQq-5pF-5@gated-at.bofh.it> (permalink)
References	<ttxhD-4AV-5@gated-at.bofh.it> <ttxUl-4RH-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Fri, 2017-04-07 at 09:52 +0100, Marc Zyngier wrote:
> On 07/04/17 09:06, Youlin Pei wrote:
> > In Mediatek SOCs, the CIRQ is a low power interrupt controller designed to
> > works outside MCUSYS which comprises with Cortex-Ax cores,CCI and GIC.
> > 
> > The CIRQ controller is integrated in between MCUSYS and interrupt sources
> > as the second level interrupt controller. The external interrupts which 
> > outside MCUSYS will feed through CIRQ then bypass to GIC.
> > 
> > In normal mode(where MCUSYS is active), CIRQ is disabled and interrupts
> > will directly issue to MCUSYS. When MCUSYS enters sleep mode, where GIC
> > is power downed. CIRQ will be enabled and monitor all edge trigger
> > interrupts(only edge trigger interrupts will be lost in this scenario).
> > When an edge interrupt is triggered, CIRQ will record the status and
> > generated a pulse signal to GIC when flush command is executed. 
> > 
> > With CIRQ, MCUSYS can be completely turned off to improve the system 
> > power consumption without losing interrupts.
> > 
> > change in v4:
> > 1. add some comment to explain CIRQ suspend callback.
> > 2. rebase on 4.11
> 
> Hi Youlin,
> 
> I'm happy to take the first two patches through the irq tree. How do we
> deal with the third one? It seems to me that it'd be better routed via
> armsoc.
> 
> Let me know what you and Matthias want to do.

Hi Marc,

Thanks for your review. I think that driver and dtsi can merged
separately.

Hi Matthias,
Could you help to review the dtsi patch?
Thanks a lot!

> 
> Thanks,
> 
> 	M.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH v4 0/3] Add Mediatek CIRQ interrupt controller Youlin Pei <youlin.pei@mediatek.com> - 2017-04-07 10:20 +0200
  [PATCH v4 1/3] binding: irqchip: mtk-cirq: Add binding document Youlin Pei <youlin.pei@mediatek.com> - 2017-04-07 10:20 +0200
  Re: [PATCH v4 0/3] Add Mediatek CIRQ interrupt controller Marc Zyngier <marc.zyngier@arm.com> - 2017-04-07 11:00 +0200
    Re: [PATCH v4 0/3] Add Mediatek CIRQ interrupt controller Youlin Pei <youlin.pei@mediatek.com> - 2017-04-07 12:00 +0200

csiph-web