Re: [PATCH 3/4] tracing: Add stack_tracer_disable/enable() functions

From	Steven Rostedt <rostedt@goodmis.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 3/4] tracing: Add stack_tracer_disable/enable() functions
Date	2017-04-07 02:00 +0200
Message-ID	<ttptM-7Ie-9@gated-at.bofh.it> (permalink)
References	(2 earlier) <ttkaJ-4pu-1@gated-at.bofh.it> <ttkDL-4B1-15@gated-at.bofh.it> <ttmcx-5J2-15@gated-at.bofh.it> <ttn8B-6iF-9@gated-at.bofh.it> <ttnUZ-6PL-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, 6 Apr 2017 15:08:21 -0700
"Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:

> On Thu, Apr 06, 2017 at 05:23:48PM -0400, Steven Rostedt wrote:
> > On Thu, 6 Apr 2017 13:21:17 -0700
> > "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> wrote:
> >   
> > > > My worry is that we add another caller that doesn't disable interrupts
> > > > or preemption.
> > > > 
> > > > I could add a __stack_trace_disable() that skips the disabling of
> > > > preemption, as the "__" usually denotes the call is "special".    
> > > 
> > > Given that interrupts are disabled at that point, and given also that
> > > NMI skips stack tracing if growth is required, could we just leave
> > > out the stack_tracer_disable() and stack_tracer_enable()?  
> > 
> > There may be other use cases. Hmm, maybe I'll just have it do a check
> > to make sure preemption is disabled. Something like:
> > 
> > 	if (IS_ENABLED(CONFIG_DEBUG_PREEMPT))
> > 		WARN_ON_ONCE(!preempt_count());  
> 
> This in the include/linux/ftrace.h file so that it can be inlined?
> That makes sense to me.
> 

Hah, I already had that part (inlining) written. It's a separate patch
though. I'll post another series tomorrow.

-- Steve

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 3/4] tracing: Add stack_tracer_disable/enable() functions Steven Rostedt <rostedt@goodmis.org> - 2017-04-06 18:50 +0200
  Re: [PATCH 3/4] tracing: Add stack_tracer_disable/enable() functions "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-04-06 20:20 +0200
    Re: [PATCH 3/4] tracing: Add stack_tracer_disable/enable()  functions Steven Rostedt <rostedt@goodmis.org> - 2017-04-06 20:50 +0200
      Re: [PATCH 3/4] tracing: Add stack_tracer_disable/enable() functions "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-04-06 22:30 +0200
        Re: [PATCH 3/4] tracing: Add stack_tracer_disable/enable()  functions Steven Rostedt <rostedt@goodmis.org> - 2017-04-06 23:30 +0200
          Re: [PATCH 3/4] tracing: Add stack_tracer_disable/enable() functions "Paul E. McKenney" <paulmck@linux.vnet.ibm.com> - 2017-04-07 00:20 +0200
            Re: [PATCH 3/4] tracing: Add stack_tracer_disable/enable()  functions Steven Rostedt <rostedt@goodmis.org> - 2017-04-07 02:00 +0200

csiph-web