Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1618391

Re: [PATCH] pinctrl: core: Fix pinctrl_register_and_init() with pinctrl_enable()

Show all headers | View raw

On Thu, Mar 30, 2017 at 6:16 PM, Tony Lindgren <tony@atomide.com> wrote:

> Recent pinctrl changes to allow dynamic allocation of pins exposed one
> more issue with the pinctrl pins claimed early by the controller itself.
> This caused a regression for IMX6 pinctrl hogs.
>
> Before enabling the pin controller driver we need to wait until it has
> been properly initialized, then claim the hogs, and only then enable it.
>
> To fix the regression, split the code into pinctrl_claim_hogs() and
> pinctrl_enable(). And then let's require that pinctrl_enable() is always
> called by the pin controller driver when ready after calling
> pinctrl_register_and_init().
>
> Depends-on: 950b0d91dc10 ("pinctrl: core: Fix regression caused by delayed
> work for hogs")
> Fixes: df61b366af26 ("pinctrl: core: Use delayed work for hogs")
> Fixes: e566fc11ea76 ("pinctrl: imx: use generic pinctrl helpers for
> managing groups")
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Gary Bisson <gary.bisson@boundarydevices.com>
> Cc: Geert Uytterhoeven <geert@linux-m68k.org>
> Cc: Haojian Zhuang <haojian.zhuang@linaro.org>
> Cc: Masahiro Yamada <yamada.masahiro@socionext.com>
> Cc: Mika Penttilä <mika.penttila@nextfour.com>
> Cc: Mika Westerberg <mika.westerberg@linux.intel.com>
> Cc: Nishanth Menon <nm@ti.com>
> Cc: Shawn Guo <shawnguo@kernel.org>
> Cc: Stefan Agner <stefan@agner.ch>
> Signed-off-by: Tony Lindgren <tony@atomide.com>

Patch applied for fixes with the test tags,
sorry for slowness.

Yours,
Linus Walleij

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] pinctrl: core: Fix pinctrl_register_and_init() with pinctrl_enable() Tony Lindgren <tony@atomide.com> - 2017-03-30 18:20 +0200
  Re: [PATCH] pinctrl: core: Fix pinctrl_register_and_init() with pinctrl_enable() Geert Uytterhoeven <geert@linux-m68k.org> - 2017-04-03 10:50 +0200
    Re: [PATCH] pinctrl: core: Fix pinctrl_register_and_init() with pinctrl_enable() Gary Bisson <gary.bisson@boundarydevices.com> - 2017-04-03 11:10 +0200
  Re: [PATCH] pinctrl: core: Fix pinctrl_register_and_init() with pinctrl_enable() Fabio Estevam <festevam@gmail.com> - 2017-04-03 14:10 +0200
  Re: [PATCH] pinctrl: core: Fix pinctrl_register_and_init() with pinctrl_enable() Linus Walleij <linus.walleij@linaro.org> - 2017-04-07 01:20 +0200

csiph-web