[PATCH] [media] media-entity: only call dev_dbg_obj if mdev is not NULL

From	Helen Koike <helen.koike@collabora.com>
Newsgroups	linux.kernel
Subject	[PATCH] [media] media-entity: only call dev_dbg_obj if mdev is not NULL
Date	2017-04-06 21:40 +0200
Message-ID	<ttlqa-58h-19@gated-at.bofh.it> (permalink)
Organization	linux.* mail to news gateway

Show all headers | View raw

Fix kernel Oops NULL pointer deference
Call dev_dbg_obj only after checking if gobj->mdev is not NULL

Signed-off-by: Helen Koike <helen.koike@collabora.com>
---
 drivers/media/media-entity.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/media/media-entity.c b/drivers/media/media-entity.c
index 5640ca2..bc44193 100644
--- a/drivers/media/media-entity.c
+++ b/drivers/media/media-entity.c
@@ -199,12 +199,12 @@ void media_gobj_create(struct media_device *mdev,
 
 void media_gobj_destroy(struct media_gobj *gobj)
 {
-	dev_dbg_obj(__func__, gobj);
-
 	/* Do nothing if the object is not linked. */
 	if (gobj->mdev == NULL)
 		return;
 
+	dev_dbg_obj(__func__, gobj);
+
 	gobj->mdev->topology_version++;
 
 	/* Remove the object from mdev list */
-- 
2.7.4

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH] [media] media-entity: only call dev_dbg_obj if mdev is not NULL Helen Koike <helen.koike@collabora.com> - 2017-04-06 21:40 +0200
  Re: [PATCH] [media] media-entity: only call dev_dbg_obj if mdev is  not NULL Sakari Ailus <sakari.ailus@iki.fi> - 2017-04-07 09:50 +0200
    Re: [PATCH] [media] media-entity: only call dev_dbg_obj if mdev is  not NULL Helen Koike <helen.koike@collabora.com> - 2017-04-07 16:40 +0200

csiph-web