Re: [PATCH net-next] net/mlx5e: fix build error without CONFIG_SYSFS

From	David Miller <davem@davemloft.net>
Newsgroups	linux.kernel
Subject	Re: [PATCH net-next] net/mlx5e: fix build error without CONFIG_SYSFS
Date	2017-04-06 22:00 +0200
Message-ID	<ttlJv-5fr-9@gated-at.bofh.it> (permalink)
References	<tsPgB-IY-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Tobias Regnery <tobias.regnery@gmail.com>
Date: Wed,  5 Apr 2017 11:11:10 +0200

> Commit 9008ae074885 ("net/mlx5e: Minimize mlx5e_{open/close}_locked")
> copied the calls to netif_set_real_num_{tx,rx}_queues from
> mlx5e_open_locked to mlx5e_activate_priv_channels and wraps them in an
> if condition to test for netdev->real_num_{tx,rx}_queues.
> 
> But netdev->real_num_rx_queues is conditionally compiled in if CONFIG_SYSFS
> is set. Without CONFIG_SYSFS the build fails:
> 
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c: In function 'mlx5e_activate_priv_channels':
> drivers/net/ethernet/mellanox/mlx5/core/en_main.c:2515:12: error: 'struct net_device' has no member named 'real_num_rx_queues'; did you mean 'real_num_tx_queues'?
> 
> Fix this by unconditionally call netif_set_real_num{tx,rx}_queues like before
> commit 9008ae074885.
> 
> Fixes: 9008ae074885 ("net/mlx5e: Minimize mlx5e_{open/close}_locked")
> Signed-off-by: Tobias Regnery <tobias.regnery@gmail.com>

Applied, thanks.

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH net-next] net/mlx5e: fix build error without CONFIG_SYSFS Tobias Regnery <tobias.regnery@gmail.com> - 2017-04-05 11:20 +0200
  Re: [PATCH net-next] net/mlx5e: fix build error without CONFIG_SYSFS Saeed Mahameed <saeedm@dev.mellanox.co.il> - 2017-04-05 17:00 +0200
  Re: [PATCH net-next] net/mlx5e: fix build error without  CONFIG_SYSFS David Miller <davem@davemloft.net> - 2017-04-06 22:00 +0200

csiph-web