Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1618255
| From | Mark Brown <broonie@kernel.org> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3] regulator: Add driver for voltage controlled regulators |
| Date | 2017-04-06 20:30 +0200 |
| Message-ID | <ttkkp-4sU-7@gated-at.bofh.it> (permalink) |
| References | <trbOh-19y-1@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Fri, Mar 31, 2017 at 01:50:35PM -0700, Matthias Kaehlcke wrote: > +- compatible : must be "vctrl-regulator". > +- regulator-min-microvolt : smallest voltage consumers may set > +- regulator-max-microvolt : largest voltage consumers may set > +- ctrl-regulator: : the name of the regulator supplying the control > + voltage. This looks good except for this bit where we read the regulator name out of the DT, that's generally a sign of bad practice for things that are less simple passives than things like this or fixed voltage regulators. As with the supplies for fixed voltage regulators just pick a name for the supply (ctrl seems fine to me) and use that, neither option is perfect but at elast this less typing for everyone and it's consistent with what other similar things are already doing.
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3] regulator: Add driver for voltage controlled regulators Matthias Kaehlcke <mka@chromium.org> - 2017-03-31 23:00 +0200
Re: [PATCH v3] regulator: Add driver for voltage controlled regulators Rob Herring <robh@kernel.org> - 2017-04-03 19:10 +0200
Re: [PATCH v3] regulator: Add driver for voltage controlled regulators Mark Brown <broonie@kernel.org> - 2017-04-06 20:30 +0200
Re: [PATCH v3] regulator: Add driver for voltage controlled regulators Matthias Kaehlcke <mka@chromium.org> - 2017-04-07 20:50 +0200
csiph-web