Re: [PATCH 4/5] vfio: platform: Convert to use devm_*()

From	Leo Yan <leo.yan@linaro.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 4/5] vfio: platform: Convert to use devm_*()
Date	2017-04-06 16:20 +0200
Message-ID	<ttgqt-1dQ-1@gated-at.bofh.it> (permalink)
References	<tphEt-1ge-5@gated-at.bofh.it> <tphEu-1ge-23@gated-at.bofh.it> <trOZj-1KM-1@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sun, Apr 02, 2017 at 04:45:28PM +0200, Auger Eric wrote:
> Hi Leo,
> 
> On 26/03/2017 16:41, Leo Yan wrote:
> > Convert driver to use devm_*() APIs so rely on driver model core layer
> > to manage resources. This eliminates error path boilerplate and makes
> > code neat.
> > 
> > This patch also renames amba_id structure, the old code used some code
> > which directly copied from other driver.
> > 
> > Signed-off-by: Leo Yan <leo.yan@linaro.org>
> Looks good to me
> Reviewed-by: Eric Auger <eric.auger@redhat.com>

Thanks for reviewing, Eric.

> May be interesting to go further converting as well the vfio-platform
> driver but this can be done later on.

Looked a bit for vfio-platform driver and I'm not sure if need some
converting within function vfio_platform_probe_common(). So I'd like
to leave this to who really understand the subsystem :)

[...]

Thanks,
Leo Yan

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

Re: [PATCH 4/5] vfio: platform: Convert to use devm_*() Auger Eric <eric.auger@redhat.com> - 2017-04-02 16:50 +0200
  Re: [PATCH 4/5] vfio: platform: Convert to use devm_*() Leo Yan <leo.yan@linaro.org> - 2017-04-06 16:20 +0200

csiph-web