Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1618030

Re: [HMM 01/16] mm/memory/hotplug: add memory type parameter to arch_add/remove_memory

Show all headers | View raw

> > diff --git a/arch/powerpc/mm/mem.c b/arch/powerpc/mm/mem.c
> > index 5f84433..0933261 100644
> > --- a/arch/powerpc/mm/mem.c
> > +++ b/arch/powerpc/mm/mem.c
> > @@ -126,14 +126,31 @@ int __weak remove_section_mapping(unsigned long
> > start, unsigned long end)
> >  	return -ENODEV;
> >  }
> >  
> > -int arch_add_memory(int nid, u64 start, u64 size, bool for_device)
> > +int arch_add_memory(int nid, u64 start, u64 size, enum memory_type type)
> >  {
> >  	struct pglist_data *pgdata;
> > -	struct zone *zone;
> >  	unsigned long start_pfn = start >> PAGE_SHIFT;
> >  	unsigned long nr_pages = size >> PAGE_SHIFT;
> > +	bool for_device = false;
> > +	struct zone *zone;
> >  	int rc;
> >  
> > +	/*
> > +	 * Each memory_type needs special handling, so error out on an
> > +	 * unsupported type. In particular, MEMORY_DEVICE_UNADDRESSABLE
> > +	 * is not supported on this architecture.
> 
> The concept of MEMORY_DEVICE_UNADDRESSABLE has not been
> introduced yet in this patch if I read correctly.

Correct, i did not want to add comment to all the arch file in the patch
that add it because this is one of the most painful patch to rebase so
instead of having more patch that are problematic for rebase i just added
the proper comment ahead of time to make my constant rebasing easier.

Cheers,
Jérôme

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[HMM 01/16] mm/memory/hotplug: add memory type parameter to arch_add/remove_memory Jérôme Glisse <jglisse@redhat.com> - 2017-04-05 22:50 +0200
  Re: [HMM 01/16] mm/memory/hotplug: add memory type parameter to  arch_add/remove_memory Anshuman Khandual <khandual@linux.vnet.ibm.com> - 2017-04-06 11:50 +0200
    Re: [HMM 01/16] mm/memory/hotplug: add memory type parameter to  arch_add/remove_memory Jerome Glisse <jglisse@redhat.com> - 2017-04-06 16:00 +0200
  Re: [HMM 01/16] mm/memory/hotplug: add memory type parameter to  arch_add/remove_memory Michal Hocko <mhocko@kernel.org> - 2017-04-07 14:20 +0200
    Re: [HMM 01/16] mm/memory/hotplug: add memory type parameter to  arch_add/remove_memory Jerome Glisse <jglisse@redhat.com> - 2017-04-07 16:40 +0200
      Re: [HMM 01/16] mm/memory/hotplug: add memory type parameter to  arch_add/remove_memory Michal Hocko <mhocko@kernel.org> - 2017-04-07 16:50 +0200
        Re: [HMM 01/16] mm/memory/hotplug: add memory type parameter to  arch_add/remove_memory Jerome Glisse <jglisse@redhat.com> - 2017-04-07 17:00 +0200
          Re: [HMM 01/16] mm/memory/hotplug: add memory type parameter to  arch_add/remove_memory Michal Hocko <mhocko@kernel.org> - 2017-04-07 17:20 +0200
            Re: [HMM 01/16] mm/memory/hotplug: add memory type parameter to  arch_add/remove_memory Jerome Glisse <jglisse@redhat.com> - 2017-04-07 18:20 +0200
              Re: [HMM 01/16] mm/memory/hotplug: add memory type parameter to  arch_add/remove_memory Michal Hocko <mhocko@kernel.org> - 2017-04-07 18:40 +0200
                Re: [HMM 01/16] mm/memory/hotplug: add memory type parameter to  arch_add/remove_memory Jerome Glisse <jglisse@redhat.com> - 2017-04-07 19:20 +0200
                Re: [HMM 01/16] mm/memory/hotplug: add memory type parameter to  arch_add/remove_memory Michal Hocko <mhocko@kernel.org> - 2017-04-07 20:00 +0200
                Re: [HMM 01/16] mm/memory/hotplug: add memory type parameter to  arch_add/remove_memory Jerome Glisse <jglisse@redhat.com> - 2017-04-07 20:30 +0200

csiph-web