Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link()

From	Amir Goldstein <amir73il@gmail.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link()
Date	2017-04-06 14:10 +0200
Message-ID	<tteoF-8jD-3@gated-at.bofh.it> (permalink)
References	(1 earlier) <tqEIF-4h2-3@gated-at.bofh.it> <tqESm-4kQ-23@gated-at.bofh.it> <tqFv4-4UX-25@gated-at.bofh.it> <tqH3P-65b-9@gated-at.bofh.it> <tqHnb-6iA-15@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Thu, Mar 30, 2017 at 3:27 PM, Richard Weinberger <richard@nod.at> wrote:
> Am 30.03.2017 um 13:57 schrieb Adrian Hunter:
>>> Reading deeper into the proved that I was wrong.
>>> AFAIKT UBIFS' journal has currently no way to revive a deleted inode.
>>> So, we have to think about a new solution.
>>
>> Deleting the orphan looks right.  Just need to understand whether the
>> recovery would do the right thing - actually it looks like O_TMPFILE might
>> be OK and in other case we might be failing to remove nodes with sequence
>> numbers greater than the deletion inode.
>
> Sadly it does not the right thing.
> I'm currently investigating why and how to deal with it.
>
> I also managed to trigger that case. :(
>

Richard,

Were you able to make any progress? still working on this?
If this is too complicated to get in for this cycle, better send a patch
to disable O_TMPFILE support for ubifs and fix the problem properly on
followup merge cycle.
Because right now ubifs O_TMPFILE support is broken and breaks overlayfs mount.

Amir.

Thread

[PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() Richard Weinberger <richard@nod.at> - 2017-03-30 11:00 +0200
  Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() Amir Goldstein <amir73il@gmail.com> - 2017-03-30 11:10 +0200
    Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() Richard Weinberger <richard@nod.at> - 2017-03-30 11:20 +0200
  Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() Amir Goldstein <amir73il@gmail.com> - 2017-03-30 11:10 +0200
    Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() Richard Weinberger <richard@nod.at> - 2017-03-30 11:20 +0200
    Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() Ralph Sennhauser <ralph.sennhauser@gmail.com> - 2017-03-30 11:20 +0200
  Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() Adrian Hunter <adrian.hunter@intel.com> - 2017-03-30 11:40 +0200
    Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() Richard Weinberger <richard@nod.at> - 2017-03-30 11:50 +0200
      Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() Richard Weinberger <richard@nod.at> - 2017-03-30 12:30 +0200
        Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() Amir Goldstein <amir73il@gmail.com> - 2017-03-30 12:40 +0200
          Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() Richard Weinberger <richard@nod.at> - 2017-03-30 13:00 +0200
        Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() Adrian Hunter <adrian.hunter@intel.com> - 2017-03-30 14:10 +0200
          Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() Richard Weinberger <richard@nod.at> - 2017-03-30 14:30 +0200
            Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() Richard Weinberger <richard@nod.at> - 2017-04-06 14:10 +0200
              Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() Richard Weinberger <richard@nod.at> - 2017-04-06 14:30 +0200
            Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() Amir Goldstein <amir73il@gmail.com> - 2017-04-06 14:10 +0200
  Re: [PATCH] ubifs: Fix O_TMPFILE corner case in ubifs_link() Hyunchul Lee <hyc.lee@gmail.com> - 2017-03-30 12:40 +0200

csiph-web