Re: [PATCH v3 02/19] HID: logitech-hidpp: Add scope to battery

From	Benjamin Tissoires <benjamin.tissoires@redhat.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH v3 02/19] HID: logitech-hidpp: Add scope to battery
Date	2017-04-06 12:10 +0200
Message-ID	<ttcwx-79y-1@gated-at.bofh.it> (permalink)
References	<tpErn-1wA-7@gated-at.bofh.it> <tpEro-1wA-11@gated-at.bofh.it> <ttcdc-6Oa-13@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Apr 06 2017 or thereabouts, Jiri Kosina wrote:
> On Mon, 27 Mar 2017, Benjamin Tissoires wrote:
> 
> > From: Bastien Nocera <hadess@hadess.net>
> > 
> > Without a scope defined, UPower assumes that the battery provides
> > power to the computer it's connected to, like a laptop battery or a UPS.
> > 
> > Tested-by: Peter Hutterer <peter.hutterer@who-t.net>
> > Signed-off-by: Bastien Nocera <hadess@hadess.net>
> > Signed-off-by: Benjamin Tissoires <benjamin.tissoires@redhat.com>
> > 
> > ---
> > 
> > no changes in v3
> > 
> > changes in v2:
> > * fixed typo in commit message
> > ---
> >  drivers/hid/hid-logitech-hidpp.c | 4 ++++
> >  1 file changed, 4 insertions(+)
> > 
> > diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
> > index 4eeb550..4aaf237 100644
> > --- a/drivers/hid/hid-logitech-hidpp.c
> > +++ b/drivers/hid/hid-logitech-hidpp.c
> > @@ -761,6 +761,7 @@ static int hidpp20_battery_event(struct hidpp_device *hidpp,
> >  static enum power_supply_property hidpp_battery_props[] = {
> >  	POWER_SUPPLY_PROP_STATUS,
> >  	POWER_SUPPLY_PROP_CAPACITY,
> > +	POWER_SUPPLY_PROP_SCOPE,
> 
> This certainly assumes some other patchset to be already applied, right?

Hehe, once again you forgot about it, and me to make a note about it
too ;-) 

> 
> Which tree is this patchset based on, please?

Your for-4.8/logitech-hidpp-battery branch :)

Cheers,
Benjamin

> 
> Thanks,
> 
> -- 
> Jiri Kosina
> SUSE Labs
>

Thread

Re: [PATCH v3 02/19] HID: logitech-hidpp: Add scope to battery Jiri Kosina <jikos@kernel.org> - 2017-04-06 11:50 +0200
  Re: [PATCH v3 02/19] HID: logitech-hidpp: Add scope to battery Benjamin Tissoires <benjamin.tissoires@redhat.com> - 2017-04-06 12:10 +0200
    Re: [PATCH v3 02/19] HID: logitech-hidpp: Add scope to battery Jiri Kosina <jikos@kernel.org> - 2017-04-06 20:40 +0200

csiph-web