Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1617791

Re: [PATCH v6] vfio error recovery: kernel support

Show all headers | View raw

On 04/06/2017 05:56 AM, Michael S. Tsirkin wrote:
> On Wed, Apr 05, 2017 at 04:54:33PM +0800, Cao jin wrote:
>> Apparently, I don't have experience to induce non-fatal error, device
>> error is more of a chance related with the environment(temperature,
>> humidity, etc) as I understand.
> 
> I'm not sure how to interpret this statement. I think what Alex is
> saying is simply that patches should include some justification. They
> make changes but what are they improving?
> For example:
> 
> 	I tested device ABC in conditions DEF. Without a patch VM
> 	stops. With the patches applied VM recovers and proceeds to
> 	use the device normally.
> 
> is one reasonable justification imho.
> 

Got it. But unfortunately, until now, I haven't seen a VM stop caused by
a real device non-fatal error during device assignment(Only saw real
fatal errors after start VM).
On one side, AER error could occur theoretically; on the other side,
seldom people have seen a VM stop caused by AER. Now I am asked that do
I have a real evidence or scenario to prove that this patchset is really
useful? I don't, and we all know it is hard to trigger a real hardware
error, so, seems I am pushed into the corner.  I guess these questions
also apply for AER driver's author, if the scenario is easy to
reproduce, there is no need to write aer_inject to fake errors.

-- 
Sincerely,
Cao jin

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

Re: [PATCH v6] vfio error recovery: kernel support Cao jin <caoj.fnst@cn.fujitsu.com> - 2017-03-28 15:50 +0200
  Re: [PATCH v6] vfio error recovery: kernel support Alex Williamson <alex.williamson@redhat.com> - 2017-03-28 18:20 +0200
    Re: [PATCH v6] vfio error recovery: kernel support "Michael S. Tsirkin" <mst@redhat.com> - 2017-03-29 02:10 +0200
      Re: [PATCH v6] vfio error recovery: kernel support Alex Williamson <alex.williamson@redhat.com> - 2017-03-29 05:00 +0200
        Re: [PATCH v6] vfio error recovery: kernel support "Michael S. Tsirkin" <mst@redhat.com> - 2017-03-30 20:10 +0200
          Re: [PATCH v6] vfio error recovery: kernel support Alex Williamson <alex.williamson@redhat.com> - 2017-03-30 20:20 +0200
            Re: [PATCH v6] vfio error recovery: kernel support Cao jin <caoj.fnst@cn.fujitsu.com> - 2017-04-05 10:50 +0200
              Re: [PATCH v6] vfio error recovery: kernel support Alex Williamson <alex.williamson@redhat.com> - 2017-04-05 21:40 +0200
                Re: [PATCH v6] vfio error recovery: kernel support "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-06 00:00 +0200
                Re: [PATCH v6] vfio error recovery: kernel support Alex Williamson <alex.williamson@redhat.com> - 2017-04-06 00:20 +0200
                Re: [PATCH v6] vfio error recovery: kernel support "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-06 00:40 +0200
                Re: [PATCH v6] vfio error recovery: kernel support Alex Williamson <alex.williamson@redhat.com> - 2017-04-06 01:00 +0200
                Re: [PATCH v6] vfio error recovery: kernel support Cao jin <caoj.fnst@cn.fujitsu.com> - 2017-04-06 11:10 +0200
                Re: [PATCH v6] vfio error recovery: kernel support Alex Williamson <alex.williamson@redhat.com> - 2017-04-06 17:40 +0200
                Re: [PATCH v6] vfio error recovery: kernel support Cao jin <caoj.fnst@cn.fujitsu.com> - 2017-04-06 11:40 +0200
              Re: [PATCH v6] vfio error recovery: kernel support "Michael S. Tsirkin" <mst@redhat.com> - 2017-04-06 00:00 +0200
                Re: [PATCH v6] vfio error recovery: kernel support Cao jin <caoj.fnst@cn.fujitsu.com> - 2017-04-06 11:40 +0200
                Re: [PATCH v6] vfio error recovery: kernel support Alex Williamson <alex.williamson@redhat.com> - 2017-04-06 17:40 +0200

csiph-web