Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1617686

Re: [PATCH 4/4] mm: memcontrol: use node page state naming scheme for memcg

From Vladimir Davydov <vdavydov.dev@gmail.com>
Newsgroups linux.kernel
Subject Re: [PATCH 4/4] mm: memcontrol: use node page state naming scheme for memcg
Date 2017-04-06 11:10 +0200
Message-ID <ttbAt-6xa-5@gated-at.bofh.it> (permalink)
References <tsEOd-2oP-7@gated-at.bofh.it> <tsEOe-2oP-21@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw

On Tue, Apr 04, 2017 at 06:01:48PM -0400, Johannes Weiner wrote:
> The memory controllers stat function names are awkwardly long and
> arbitrarily different from the zone and node stat functions.
> 
> The current interface is named:
> 
>   mem_cgroup_read_stat()
>   mem_cgroup_update_stat()
>   mem_cgroup_inc_stat()
>   mem_cgroup_dec_stat()
>   mem_cgroup_update_page_stat()
>   mem_cgroup_inc_page_stat()
>   mem_cgroup_dec_page_stat()
> 
> This patch renames it to match the corresponding node stat functions:
> 
>   memcg_page_state()		[node_page_state()]
>   mod_memcg_state()		[mod_node_state()]
>   inc_memcg_state()		[inc_node_state()]
>   dec_memcg_state()		[dec_node_state()]
>   mod_memcg_page_state()	[mod_node_page_state()]
>   inc_memcg_page_state()	[inc_node_page_state()]
>   dec_memcg_page_state()	[dec_node_page_state()]
> 
> Signed-off-by: Johannes Weiner <hannes@cmpxchg.org>

Looks neat.

Acked-by: Vladimir Davydov <vdavydov.dev@gmail.com>

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 1/4] mm: memcontrol: clean up memory.events counting function Johannes Weiner <hannes@cmpxchg.org> - 2017-04-05 00:10 +0200
  [PATCH 4/4] mm: memcontrol: use node page state naming scheme for memcg Johannes Weiner <hannes@cmpxchg.org> - 2017-04-05 00:10 +0200
    Re: [PATCH 4/4] mm: memcontrol: use node page state naming scheme  for memcg Vladimir Davydov <vdavydov.dev@gmail.com> - 2017-04-06 11:10 +0200
    Re: [PATCH 4/4] mm: memcontrol: use node page state naming scheme  for memcg Michal Hocko <mhocko@kernel.org> - 2017-04-07 15:00 +0200
  [PATCH 2/4] mm: memcontrol: re-use global VM event enum Johannes Weiner <hannes@cmpxchg.org> - 2017-04-05 00:10 +0200
    Re: [PATCH 2/4] mm: memcontrol: re-use global VM event enum Vladimir Davydov <vdavydov.dev@gmail.com> - 2017-04-06 10:50 +0200
      Re: [PATCH 2/4] mm: memcontrol: re-use global VM event enum Johannes Weiner <hannes@cmpxchg.org> - 2017-04-10 16:20 +0200
    Re: [PATCH 2/4] mm: memcontrol: re-use global VM event enum Michal Hocko <mhocko@kernel.org> - 2017-04-07 14:50 +0200
      Re: [PATCH 2/4] mm: memcontrol: re-use global VM event enum Johannes Weiner <hannes@cmpxchg.org> - 2017-04-10 16:20 +0200
  Re: [PATCH 1/4] mm: memcontrol: clean up memory.events counting  function Vladimir Davydov <vdavydov.dev@gmail.com> - 2017-04-06 10:40 +0200
  Re: [PATCH 1/4] mm: memcontrol: clean up memory.events counting  function Michal Hocko <mhocko@kernel.org> - 2017-04-07 14:30 +0200

csiph-web