Groups > linux.kernel > #1619263

Re: [PATCH v2] staging: vt6656: fixed an indentation coding style issue

From	Greg KH <gregkh@linuxfoundation.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH v2] staging: vt6656: fixed an indentation coding style issue
Date	2017-04-08 13:00 +0200
Message-ID	<ttWg2-4d3-5@gated-at.bofh.it> (permalink)
References	<toSPM-Cr-9@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Sat, Mar 25, 2017 at 05:40:48PM +0530, Prasant Jalan wrote:
> 
> Replacing spaces with tabs for indetation to fix checkpatch.pl error
> "code indent should use tabs where possible".
> 
> 
> Signed-off-by: Prasant Jalan <prasant.jalan@gmail.com>
> ---
> 
>   v2:
>     - improved changelog comments
>     - fixed only one issue
> 
> 
>  drivers/staging/vt6656/rxtx.c | 35 +++++++++++++++++++----------------
>  1 file changed, 19 insertions(+), 16 deletions(-)
> 
> diff --git a/drivers/staging/vt6656/rxtx.c b/drivers/staging/vt6656/rxtx.c
> index 1835cd1..7ebd1ee 100644
> --- a/drivers/staging/vt6656/rxtx.c
> +++ b/drivers/staging/vt6656/rxtx.c
> @@ -114,7 +114,7 @@ static __le16 vnt_time_stamp_off(struct vnt_private *priv, u16 rate)
>  }
>  
>  static u32 vnt_get_rsvtime(struct vnt_private *priv, u8 pkt_type,
> -	                    u32 frame_length, u16 rate, int need_ack)
> +				u32 frame_length, u16 rate, int need_ack)

No, it should look like:

			      u32 frame_length, u16 rate, int need_ack)

Please fix them up that way.

thanks,

greg k-h

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

Re: [PATCH v2] staging: vt6656: fixed an indentation coding style  issue Greg KH <gregkh@linuxfoundation.org> - 2017-04-08 13:00 +0200

csiph-web