Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1619259

Re: [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()")

Path csiph.com!news.redatomik.org!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From Francois Romieu <romieu@fr.zoreil.com>
Newsgroups linux.kernel
Subject Re: [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()")
Date Sat, 08 Apr 2017 12:40:01 +0200
Message-ID <ttVWF-452-5@gated-at.bofh.it> (permalink)
References <ttGEi-2A6-7@gated-at.bofh.it> <ttGXF-2Kw-43@gated-at.bofh.it> <ttH7k-2Ox-7@gated-at.bofh.it>
X-Original-To ville.syrjala@linux.intel.com
X-Greylist delayed 576 seconds by postgrey-1.27 at vger.kernel.org; Sat, 08 Apr 2017 06:32:49 EDT
MIME-Version 1.0
Content-Type text/plain; charset=us-ascii
Content-Disposition inline
X-Organisation Land of Sunshine Inc.
User-Agent Mutt/1.5.23 (2014-03-12)
Sender robomod@news.nic.it
List-ID <linux-kernel.vger.kernel.org>
X-Mailing-List linux-kernel@vger.kernel.org
Approved robomod@news.nic.it
Lines 16
Organization linux.* mail to news gateway
X-Original-Cc David Miller <davem@davemloft.net>, eric.dumazet@gmail.com, edumazet@google.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org
X-Original-Date Sat, 8 Apr 2017 12:23:05 +0200
X-Original-Message-ID <20170408102305.GA4522@electric-eye.fr.zoreil.com>
X-Original-References <20170407181754.GL30290@intel.com> <1491590329.10124.86.camel@edumazet-glaptop3.roam.corp.google.com> <20170407.114216.29873489271414092.davem@davemloft.net>
X-Original-Sender linux-kernel-owner@vger.kernel.org
Xref csiph.com linux.kernel:1619259

Show key headers only | View raw


David Miller <davem@davemloft.net> :
[...]
> One theory is that the interrupt masking isn't working properly
> and interrupts are still arriving and hitting the NAPI state even
> when we are actively polling NAPI.
> 
> And this problem was masked by the locking done here.

Yes.

Ville, can you rule out irq sharing between the 8139 and some other
device ? It's a candidate for unexpected interrupt handler invocation
with older pc, even with properly working hardware.

-- 
Ueimor

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread


Thread

[regression v4.11] 617f01211baf ("8139too: use napi_complete_done()") Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-04-07 20:20 +0200
  Re: [regression v4.11] 617f01211baf ("8139too: use  napi_complete_done()") Eric Dumazet <eric.dumazet@gmail.com> - 2017-04-07 20:40 +0200
    Re: [regression v4.11] 617f01211baf ("8139too: use  napi_complete_done()") David Miller <davem@davemloft.net> - 2017-04-07 20:50 +0200
      Re: [regression v4.11] 617f01211baf ("8139too: use  napi_complete_done()") Francois Romieu <romieu@fr.zoreil.com> - 2017-04-08 12:40 +0200
        Re: [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()") tedheadster <tedheadster@gmail.com> - 2017-04-10 16:30 +0200
          Re: [regression v4.11] 617f01211baf ("8139too: use napi_complete_done()") Eric Dumazet <edumazet@google.com> - 2017-04-10 17:00 +0200
    Re: [regression v4.11] 617f01211baf ("8139too: use  napi_complete_done()") Ville Syrjälä <ville.syrjala@linux.intel.com> - 2017-04-10 14:20 +0200

csiph-web