Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1619184
| Path | csiph.com!feeder.erje.net!1.us.feeder.erje.net!newsfeed.fsmpi.rwth-aachen.de!newsfeed.straub-nv.de!news.unit0.net!news.panservice.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Taeung Song <treeze.taeung@gmail.com> |
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 5/5] perf tools: Refactor the code to strip command name with {l,r}trim() |
| Date | Sat, 08 Apr 2017 03:00:02 +0200 |
| Message-ID | <ttMTo-6DM-21@gated-at.bofh.it> (permalink) |
| References | <ttMTn-6DM-9@gated-at.bofh.it> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=rSFbRtz5SYRFD2X33GBPlMsQsfDlBTyrmxJJdW3wAVg=; b=vhOV15ahOURW+0ha+b+sNdO8Xzbrq9Sp3p4iD7Q2KKdc0hdYhYu2OupgvFc0/mbMoL HelM45VI4wmLXWFlJ9vFXuqKz4nrblCciyglfNEPVluLhip1bJfAjelzPqSwZmxdtUjv yGNdfgMzwK0ibK5ZSWxLmnmkryGQwjK1AF5F4NTyR1lGwYStd8+5J4TXbSbYl8CJc5tT aeWJcO0sZxrtYI91iev5DUqpTqCF1DSYGQ+bPt6HlyKiMtgrx5EBNFEyCNRDveclh/kk lt4vqkvm7ciB4pxg4yaVvweB3gynVKHu4k2BVhqmwC4ABFg8SbhbKu3U43WZyqRL8HHZ 0H2g== |
| X-Google-Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=rSFbRtz5SYRFD2X33GBPlMsQsfDlBTyrmxJJdW3wAVg=; b=grpmQ7s/HCS8j0qJNIZowF31hwkAUJ21ztGhj2MfZYHV+Pb1TEfisu78s7IOo2PQWv oVQLwoMI+WnenWIWu0pbwm2Ivzlfx7E1fG1FTo7qGnqhqIak31COsdf6ktaG++5GtVHJ grb8FgNA9ed7/QiO6xdeGlbMn9VLfSXVFe7GgmacaxEnBD+qnOoqkrvw72yLhx7B0Ej0 1kF8j/MaPNloM+v9kgQY+n54yDbT0N+J1YEGOIP21bfVgSpCK94rYmgQZnatVzeyINfh Xyftkx0QO7G9w1MhAkFDZG/vbn6++qyBUz+Qq14czHBKQdnWyWrEFNnO8KCOpIYJBx0I 4JtA== |
| X-Gm-Message-State | AN3rC/6JUnwTIE+4B+npochdAWKVRIVRsN50EeX4yDiczGuUVUTZkvHhVZkCffAUnm4rPw== |
| X-Received | by 10.84.241.129 with SMTP id b1mr508399pll.107.1491612763922; Fri, 07 Apr 2017 17:52:43 -0700 (PDT) |
| X-Mailer | git-send-email 2.7.4 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 44 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | linux-kernel@vger.kernel.org, Taeung Song <treeze.taeung@gmail.com>, David Ahern <dsahern@gmail.com>, Don Zickus <dzickus@redhat.com>, Jiri Olsa <jolsa@kernel.org>, Namhyung Kim <namhyung@kernel.org> |
| X-Original-Date | Sat, 8 Apr 2017 09:52:28 +0900 |
| X-Original-Message-ID | <1491612748-1605-6-git-send-email-treeze.taeung@gmail.com> |
| X-Original-References | <1491612748-1605-1-git-send-email-treeze.taeung@gmail.com> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1619184 |
Show key headers only | View raw
After reading command name from /proc/<pid>/status,
use ltrim() and rtrim() to strip command name, not using
just while loop, isspace() and etc.
Cc: David Ahern <dsahern@gmail.com>
Cc: Don Zickus <dzickus@redhat.com>
Cc: Jiri Olsa <jolsa@kernel.org>
Cc: Namhyung Kim <namhyung@kernel.org>
Signed-off-by: Taeung Song <treeze.taeung@gmail.com>
---
tools/perf/util/event.c | 11 ++---------
1 file changed, 2 insertions(+), 9 deletions(-)
diff --git a/tools/perf/util/event.c b/tools/perf/util/event.c
index 76b9c6b..8255a26 100644
--- a/tools/perf/util/event.c
+++ b/tools/perf/util/event.c
@@ -106,7 +106,7 @@ static int perf_event__get_comm_ids(pid_t pid, char *comm, size_t len,
int fd;
size_t size = 0;
ssize_t n;
- char *nl, *name, *tgids, *ppids;
+ char *name, *tgids, *ppids;
*tgid = -1;
*ppid = -1;
@@ -134,14 +134,7 @@ static int perf_event__get_comm_ids(pid_t pid, char *comm, size_t len,
if (name) {
name += 5; /* strlen("Name:") */
-
- while (*name && isspace(*name))
- ++name;
-
- nl = strchr(name, '\n');
- if (nl)
- *nl = '\0';
-
+ name = rtrim(ltrim(name));
size = strlen(name);
if (size >= len)
size = len - 1;
--
2.7.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/5] Refactoring with ltrim() and rtrim() Taeung Song <treeze.taeung@gmail.com> - 2017-04-08 03:00 +0200
[PATCH v2 5/5] perf tools: Refactor the code to strip command name with {l,r}trim() Taeung Song <treeze.taeung@gmail.com> - 2017-04-08 03:00 +0200
Re: [PATCH v2 5/5] perf tools: Refactor the code to strip command name with {l,r}trim() David Ahern <dsahern@gmail.com> - 2017-04-08 20:50 +0200
Re: [PATCH v2 5/5] perf tools: Refactor the code to strip command name with {l,r}trim() Taeung Song <treeze.taeung@gmail.com> - 2017-04-09 07:40 +0200
[PATCH v2 3/5] perf ui browser: Refactor the code to parse color configs with ltrim() Taeung Song <treeze.taeung@gmail.com> - 2017-04-08 03:00 +0200
csiph-web