Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1619117

[PATCH 10/10] orangefs: do not check possibly stale size on truncate

Show all headers | View raw

Let the server figure this out because our size might be out of date or
not present.

The bug was that

	xfs_io -f -t -c "pread -v 0 100" /mnt/foo
	echo "Test" > /mnt/foo
	xfs_io -f -t -c "pread -v 0 100" /mnt/foo

fail because the second truncate did not happen if nothing had requested
the size after the write in echo.  Thus i_size was zero (not present)
and the orangefs_setattr though i_size was zero and there was nothing to
do.

Signed-off-by: Martin Brandenburg <martin@omnibond.com>
---
 fs/orangefs/inode.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/orangefs/inode.c b/fs/orangefs/inode.c
index ee28364..7f82e56 100644
--- a/fs/orangefs/inode.c
+++ b/fs/orangefs/inode.c
@@ -218,8 +218,7 @@ int orangefs_setattr(struct dentry *dentry, struct iattr *iattr)
 	if (ret)
 		goto out;
 
-	if ((iattr->ia_valid & ATTR_SIZE) &&
-	    iattr->ia_size != i_size_read(inode)) {
+	if (iattr->ia_valid & ATTR_SIZE) {
 		ret = orangefs_setattr_size(inode, iattr);
 		if (ret)
 			goto out;
-- 
2.1.4

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH 00/10] orangefs changes for 4.12 Martin Brandenburg <martin@omnibond.com> - 2017-04-07 23:20 +0200
  [PATCH 10/10] orangefs: do not check possibly stale size on truncate Martin Brandenburg <martin@omnibond.com> - 2017-04-07 23:20 +0200
  [PATCH 06/10] orangefs: support llseek on directories Martin Brandenburg <martin@omnibond.com> - 2017-04-07 23:20 +0200
  [PATCH 08/10] orangefs: remove ORANGEFS_READDIR macros Martin Brandenburg <martin@omnibond.com> - 2017-04-07 23:20 +0200
  [PATCH 05/10] orangefs: rewrite readdir to fix several bugs Martin Brandenburg <martin@omnibond.com> - 2017-04-07 23:20 +0200
  [PATCH 03/10] orangefs: clean up oversize xattr validation Martin Brandenburg <martin@omnibond.com> - 2017-04-07 23:30 +0200
  [PATCH 01/10] orangefs: remove unused get_fsid_from_ino Martin Brandenburg <martin@omnibond.com> - 2017-04-07 23:30 +0200

csiph-web