Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1619016

[PATCH 1/1] memory: tegra: fix fdc test bug

Show all headers | View raw

The fdc variable is a bool, taking the address of this will generally
produce true, thus skewing any users of the tegra_mc_set_latency_allowance
code.

Note, this does not seem to be producing a compiler warning. This was only
spotted as it meant a caller was seeing 3 times higher than expected
register results.

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
 drivers/memory/tegra/mc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/memory/tegra/mc.c b/drivers/memory/tegra/mc.c
index fb44d1741862..e20470736319 100644
--- a/drivers/memory/tegra/mc.c
+++ b/drivers/memory/tegra/mc.c
@@ -121,7 +121,7 @@ int tegra_mc_set_latency_allowance(int client_id, unsigned int bandwidth)
 
 	WARN_ON(client->id != client_id);
 
-	if (&client->fdc)
+	if (client->fdc)
 		atom_bytes = plat_mc->soc->atom_size_fdc;
 	else
 		atom_bytes = plat_mc->soc->atom_size;
-- 
2.11.0

Back to linux.kernel | Previous | Next | Find similar | Unroll thread

Thread

[PATCH 1/1] memory: tegra: fix fdc test bug Ben Dooks <ben.dooks@codethink.co.uk> - 2017-04-07 20:10 +0200

csiph-web