Re: [PATCH] net: ipv6: Removed unnecessary parenthesis

From	Pablo Neira Ayuso <pablo@netfilter.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH] net: ipv6: Removed unnecessary parenthesis
Date	2017-04-07 18:40 +0200
Message-ID	<ttF5w-1hT-29@gated-at.bofh.it> (permalink)
References	<tqhM5-4Lj-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Wed, Mar 29, 2017 at 02:32:43PM +0530, Arushi Singhal wrote:
> Removed parentheses on the right hand side of assignment, as they are
> not required. The following coccinelle script was used to fix this
> issue:
> 
> @@
> local idexpression id;
> expression e;
> @@
> 
> id =
> -(
> e
> -)

You sent me two patches for this:

http://patchwork.ozlabs.org/patch/744661/
http://patchwork.ozlabs.org/patch/744702/

The follow up one does not indicate v2, so I'm confused. I'm not sure
this is a resend or just a new version.

Another question that is not clear from your description is if you had
a look at the entire tree to find more spots like this, or you just
found this one and update it.

Ideally, it would be better to fix everything in one go, so we don't
have to deal with oneliner patches that just fix one single spot.

Thanks!

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] net: ipv6: Removed unnecessary parenthesis Arushi Singhal <arushisinghal19971997@gmail.com> - 2017-03-29 11:10 +0200
  Re: [PATCH] net: ipv6: Removed unnecessary parenthesis Pablo Neira Ayuso <pablo@netfilter.org> - 2017-04-07 18:40 +0200

csiph-web