Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1618943
| From | <cristian.birsan@microchip.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | [PATCH v4 1/2] usb: gadget: udc: atmel: Use dev_err() to display EP configuration error |
| Date | 2017-04-07 18:20 +0200 |
| Message-ID | <ttEMa-18X-21@gated-at.bofh.it> (permalink) |
| References | <ttEM9-18X-3@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
From: Cristian Birsan <cristian.birsan@microchip.com> Use dev_err() to display EP configuration error to avoid silent failure. Signed-off-by: Cristian Birsan <cristian.birsan@microchip.com> Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com> --- drivers/usb/gadget/udc/atmel_usba_udc.c | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/usb/gadget/udc/atmel_usba_udc.c b/drivers/usb/gadget/udc/atmel_usba_udc.c index 8bc0b52a..3ccc341 100644 --- a/drivers/usb/gadget/udc/atmel_usba_udc.c +++ b/drivers/usb/gadget/udc/atmel_usba_udc.c @@ -1851,8 +1851,8 @@ static irqreturn_t usba_udc_irq(int irq, void *devid) * but it's clearly harmless... */ if (!(usba_ep_readl(ep0, CFG) & USBA_EPT_MAPPED)) - dev_dbg(&udc->pdev->dev, - "ODD: EP0 configuration is invalid!\n"); + dev_err(&udc->pdev->dev, + "ODD: EP0 configuration is invalid!\n"); /* Preallocate other endpoints */ n = fifo_mode ? udc->num_ep : udc->configured_ep; @@ -1860,8 +1860,8 @@ static irqreturn_t usba_udc_irq(int irq, void *devid) ep = &udc->usba_ep[i]; usba_ep_writel(ep, CFG, ep->ept_cfg); if (!(usba_ep_readl(ep, CFG) & USBA_EPT_MAPPED)) - dev_dbg(&udc->pdev->dev, - "ODD: EP%d configuration is invalid!\n", i); + dev_err(&udc->pdev->dev, + "ODD: EP%d configuration is invalid!\n", i); } } -- 2.7.4
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v4 0/2] usb: gadget: udc: atmel: Endpoint allocation scheme fixes <cristian.birsan@microchip.com> - 2017-04-07 18:20 +0200 [PATCH v4 1/2] usb: gadget: udc: atmel: Use dev_err() to display EP configuration error <cristian.birsan@microchip.com> - 2017-04-07 18:20 +0200 [PATCH v4 2/2] usb: gadget: udc: atmel: Update Kconfig help for fifo_mode = 0 <cristian.birsan@microchip.com> - 2017-04-07 18:20 +0200
csiph-web