Re: [PATCH] RDS: IB: ensure an initialized ret is printed in pr_warn message

From	Santosh Shilimkar <santosh.shilimkar@oracle.com>
Newsgroups	linux.kernel
Subject	Re: [PATCH] RDS: IB: ensure an initialized ret is printed in pr_warn message
Date	2017-04-07 18:10 +0200
Message-ID	<ttECu-13t-15@gated-at.bofh.it> (permalink)
References	<ttwYi-4eW-13@gated-at.bofh.it> <ttD3J-8io-37@gated-at.bofh.it>
Organization	Oracle Corporation

Show all headers | View raw

On 4/7/2017 7:24 AM, Dan Carpenter wrote:
> Setting it to zero doesn't seem like the right thing, it should be an
> error code.  Oh, heh...  Smatch parses this one correctly.  "ret" is
> always initialized but the code is probably buggy in a different way:
>

[...]

>    561                  ibmr = rds_ib_reg_fmr(rds_ibdev, sg, nents, key_ret);
>    562          if (ibmr)
>                     ^^^^
> This condition is always true because those functions return ERR_PTRs
> not NULLs.
>
Thanks Dan. I will fix that up.

Regards,
Santosh

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH] RDS: IB: ensure an initialized ret is printed in pr_warn message Colin King <colin.king@canonical.com> - 2017-04-07 10:00 +0200
  Re: [PATCH] RDS: IB: ensure an initialized ret is printed in  pr_warn message David Miller <davem@davemloft.net> - 2017-04-07 15:20 +0200
  Re: [PATCH] RDS: IB: ensure an initialized ret is printed in pr_warn  message Dan Carpenter <dan.carpenter@oracle.com> - 2017-04-07 16:30 +0200
    Re: [PATCH] RDS: IB: ensure an initialized ret is printed in pr_warn  message Santosh Shilimkar <santosh.shilimkar@oracle.com> - 2017-04-07 18:10 +0200

csiph-web