[PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs

Path	csiph.com!news.mixmin.net!aioe.org!news.servidellagleba.it!bofh.it!news.nic.it!robomod
From	Joerg Roedel <joro@8bytes.org>
Newsgroups	linux.kernel
Subject	[PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs
Date	Fri, 07 Apr 2017 16:40:02 +0200
Message-ID	<ttDdo-8mD-27@gated-at.bofh.it> (permalink)
Dkim-Signature	v=1; a=rsa-sha256; c=simple/simple; d=8bytes.org; s=mail-1; t=1491575542; bh=tnPGior81rV7Oo84dIYJDInpxSl0IJ2hluGFC/fZMYw=; h=From:To:Cc:Subject:Date:From; b=Up18t1QOyWXwM6xYKce2kMcilghteKxpJ6hYgwnUMAEROtcIbWc4w74Vm5O9kLhzy vpuvmfHH3UnaeoRXlyM0Cys11hFS4Hi0ND5/sOkuKaSIrkxFBeeyksSgLKSv6QL8Cl YaXKIyhG48YFBpLo19pk6uhc2xHyDfl1gNkYYIYGooZh0Eb3FEsrpw4TzT0QyBsmV7 yijqNxjrThjcSkYJjBVeUUAcITzeSGHXs3UZCzv+SZbshJx8Se8zZin5qB1tEQoGEj hH2OIQ9nQnL2N2S9l+8W6ekdTwlZtxFg8xMgWIFrQeiSlHnrEQfg2F7SzlDUgX1870 FFwcS8Vqhy7OQ==
X-Mailer	git-send-email 1.9.1
Sender	robomod@news.nic.it
List-ID	<linux-kernel.vger.kernel.org>
X-Mailing-List	linux-kernel@vger.kernel.org
Approved	robomod@news.nic.it
Lines	45
Organization	linux.* mail to news gateway
X-Original-Cc	linux-pci@vger.kernel.org, linux-kernel@vger.kernel.org, Daniel Drake <drake@endlessm.com>, Alexander Deucher <Alexander.Deucher@amd.com>, Samuel Sieb <samuel@sieb.net>, David Woodhouse <dwmw2@infradead.org>, Joerg Roedel <jroedel@suse.de>
X-Original-Date	Fri, 7 Apr 2017 16:32:18 +0200
X-Original-Message-ID	<1491575538-22694-1-git-send-email-joro@8bytes.org>
X-Original-Sender	linux-kernel-owner@vger.kernel.org
Xref	csiph.com linux.kernel:1618858

Show key headers only | View raw

From: Joerg Roedel <jroedel@suse.de>

ATS is broken on this hardware and causes IOMMU stalls and
system failure. Disable ATS on these devices to make them
usable again with IOMMU enabled.

Note that the commit in the Fixes-tag is not buggy, it
just uncovers the problem in the hardware by increasing
the ATS-flush rate.

Fixes: b1516a14657a ('iommu/amd: Implement flush queue')
Signed-off-by: Joerg Roedel <jroedel@suse.de>
---
 drivers/pci/quirks.c | 19 +++++++++++++++++++
 1 file changed, 19 insertions(+)

diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c
index 6736836..7cbe316 100644
--- a/drivers/pci/quirks.c
+++ b/drivers/pci/quirks.c
@@ -4634,3 +4634,22 @@ static void quirk_no_aersid(struct pci_dev *pdev)
 DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x2031, quirk_no_aersid);
 DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x2032, quirk_no_aersid);
 DECLARE_PCI_FIXUP_EARLY(PCI_VENDOR_ID_INTEL, 0x2033, quirk_no_aersid);
+
+#ifdef CONFIG_PCI_ATS
+/*
+ * Some devices have a broken ATS implementation causing IOMMU stalls.
+ * Don't use ATS for those devices.
+ */
+static void quirk_disable_ats(struct pci_dev *pdev)
+{
+	/*
+	 * Set pdev->ats_cap = 0 to make pci_enable_ats() bail out
+	 * early.
+	 */
+	dev_info(&pdev->dev, "QUIRK: Disabling ATS");
+	pdev->ats_cap = 0;
+}
+
+/* AMD Stoney platform GPU */
+DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_ATI, 0x98e4, quirk_disable_ats);
+#endif /* CONFIG_PCI_ATS */
-- 
1.9.1

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs Joerg Roedel <joro@8bytes.org> - 2017-04-07 16:40 +0200
  RE: [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs "Deucher, Alexander" <Alexander.Deucher@amd.com> - 2017-04-07 18:50 +0200
  Re: [PATCH v2] PCI: Add ATS-disable quirk for AMD Stoney GPUs Lukas Wunner <lukas@wunner.de> - 2017-04-08 09:50 +0200

csiph-web