Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1618770
| Path | csiph.com!news.mixmin.net!border2.nntp.ams1.giganews.com!nntp.giganews.com!news.panservice.it!bofh.it!news.nic.it!robomod |
|---|---|
| From | Andrew Jeffery <andrew@aj.id.au> |
| Newsgroups | linux.kernel |
| Subject | [PATCH v2 4/4] gpio: aspeed: Add open-source and open-drain support |
| Date | Fri, 07 Apr 2017 15:10:01 +0200 |
| Message-ID | <ttBOh-7vK-5@gated-at.bofh.it> (permalink) |
| References | <ttBOh-7vK-3@gated-at.bofh.it> |
| X-Original-To | Linus Walleij <linus.walleij@linaro.org> |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d=aj.id.au; h=cc :date:from:in-reply-to:message-id:references:subject:to :x-me-sender:x-me-sender:x-sasl-enc:x-sasl-enc; s=fm1; bh=YRa4Iy 39H6d7GxiiFHxcfcdkIUfrFzIqUldPKBGQaVY=; b=C/Hy+taAB7DibwDFu5XbAc n6GEV+HPz+8yT85OlKAuXFvtJt/uNzI5ZQJbQmv4X5w/bgNIrxryebnxRpH2LIaK JEdLyffY/er4yPn6CYYQH896MrA8gzmW+zdCbATHv3KIWpv1HiXE/HnyR6mpmwmU /D2xWWcPzQDXTKQGAa+HM39kgnKOWr8EmFZA94UO/K3DZ0vg9LfiMwYk32oUpWwP kKeYHuIRS7wqP5ERl5TwEPRP8K8/pG9akA3j/an7tgLnZ4B3H3sf/7+MZ3o8ROnm NT5clQngULydr6mYGqA9z8AkJ2KLUUbK0CIy4gemiK8FpoMrErCnWG02NjbM1lJA == |
| Dkim-Signature | v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:date:from:in-reply-to:message-id :references:subject:to:x-me-sender:x-me-sender:x-sasl-enc :x-sasl-enc; s=fm1; bh=YRa4Iy39H6d7GxiiFHxcfcdkIUfrFzIqUldPKBGQa VY=; b=sD6bbTX+v4ggFf9M+YGa9uZzIG+Q06Dm17ucKLmb2836fSz51fSF72FN/ Mf2gqsilaneDWHrp/sDk1y9g+tNheQf76duSqnRrcBnK69LRnlOrTuMJE7vg7Oz2 8CPkv1M9tqmi4AsfIpI5G0p49I4rSlTWz0cX6eaojMfJ+FyQin0H1F+cCVY8YddC xOnWelCh6Pg95MbkCpRifUtyOKMj1p4DjSaVx2MvJj49/HBoJm3Mlrpvfni7Hfuw FNhCDwgBpY3tAZSlmVFa08AsPfBKVPSWfy3uAiiVuMdoumLLW+BMmaElhVLW+YDe gyMmSEKuFGlL8i3MUdzYDihkwW99A== |
| X-Me-Sender | <xms:OI3nWDztMgEMuzY_eWpgaHZT9gwu-8fRa5PHZRseqEwsfXIdNBFUuQ> |
| X-Sasl-Enc | WMlcn5nuH0ozQqp4aaPOZ/ArGvaLPVVH/VNupSlvcnqO 1491569975 |
| X-Mailer | git-send-email 2.9.3 |
| Sender | robomod@news.nic.it |
| List-ID | <linux-kernel.vger.kernel.org> |
| X-Mailing-List | linux-kernel@vger.kernel.org |
| Approved | robomod@news.nic.it |
| Lines | 29 |
| Organization | linux.* mail to news gateway |
| X-Original-Cc | Andrew Jeffery <andrew@aj.id.au>, Rob Herring <robh+dt@kernel.org>, Joel Stanley <joel@jms.id.au>, Benjamin Herrenschmidt <benh@kernel.crashing.org>, linux-gpio@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org |
| X-Original-Date | Fri, 7 Apr 2017 22:29:02 +0930 |
| X-Original-Message-ID | <20170407125902.15960-5-andrew@aj.id.au> |
| X-Original-References | <20170407125902.15960-1-andrew@aj.id.au> |
| X-Original-Sender | linux-kernel-owner@vger.kernel.org |
| Xref | csiph.com linux.kernel:1618770 |
Show key headers only | View raw
As per the datasheet, manage the IO and value states to implement open-source/open-drain, but do this by falling back to gpiolib's emulation. This commit simply makes the behaviour explicit for clarity, rather than relying on the implicit return of -ENOTSUPP to trigger the emulation. Signed-off-by: Andrew Jeffery <andrew@aj.id.au> --- drivers/gpio/gpio-aspeed.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/drivers/gpio/gpio-aspeed.c b/drivers/gpio/gpio-aspeed.c index 3327a48df862..ccea609676ee 100644 --- a/drivers/gpio/gpio-aspeed.c +++ b/drivers/gpio/gpio-aspeed.c @@ -761,6 +761,10 @@ static int aspeed_gpio_set_config(struct gpio_chip *chip, unsigned int offset, param == PIN_CONFIG_BIAS_PULL_DOWN || param == PIN_CONFIG_DRIVE_STRENGTH) return pinctrl_gpio_set_config(offset, config); + else if (param == PIN_CONFIG_DRIVE_OPEN_DRAIN || + param == PIN_CONFIG_DRIVE_OPEN_SOURCE) + /* Return -ENOTSUPP to trigger emulation, as per datasheet */ + return -ENOTSUPP; return -ENOTSUPP; } -- 2.9.3
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v2 0/4] gpio: aspeed: Add debounce support Andrew Jeffery <andrew@aj.id.au> - 2017-04-07 15:10 +0200 [PATCH v2 4/4] gpio: aspeed: Add open-source and open-drain support Andrew Jeffery <andrew@aj.id.au> - 2017-04-07 15:10 +0200 [PATCH v2 3/4] gpio: aspeed: Add debounce support Andrew Jeffery <andrew@aj.id.au> - 2017-04-07 15:10 +0200 [PATCH v2 1/4] gpio: aspeed: dt: Fix description alignment in bindings document Andrew Jeffery <andrew@aj.id.au> - 2017-04-07 15:10 +0200
csiph-web