Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1618718

Re: [Patch v4 12/12] Documention: v4l: Documentation for HEVC CIDs

Show key headers only | View raw

On Fri, 2017-04-07 at 12:26 +0200, Sylwester Nawrocki wrote:
> On 04/07/2017 12:03 PM, Smitha T Murthy wrote:
> >>> +``V4L2_CID_MPEG_VIDEO_HEVC_LF``
> >>> +    Indicates loop filtering. Control ID 0 indicates loop filtering
> >>> +    is enabled and when set to 1 indicates no filter.
>  >>
> >> "Setting this control to 0 enables loop filtering, setting this control
> >> to 1 disables loop filtering." ?
> >>
> >> Couldn't the meaning be inverted, so setting the control to 0 disables
> >> the loop filtering?
> >>
> >>From register point of view, this control value needs be 0 to enable
> > loop filtering.
> 
> OK, this is true for our specific hardware/firmware implementation.
> 
> In general, for this user space interface I would rather define that
> boolean control so value 1 enables LF and value 0 disables LF.
> The driver could simply negate the value when writing registers.
> 
> BTW we might need to specify type of the control here as Hans suggested
> commenting on other control.
> 
> --
> Regards,
> Sylwester
> 
Ok I will change the implementation from the driver for this control.
Yes in the next version I will add the type of the control for all.

Thank you for the review.

Regards,
Smitha

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[Patch v4 00/12] Add MFC v10.10 support Smitha T Murthy <smitha.t@samsung.com> - 2017-04-06 08:20 +0200
  [Patch v4 01/12] [media] s5p-mfc: Rename IS_MFCV8 macro Smitha T Murthy <smitha.t@samsung.com> - 2017-04-06 08:20 +0200
  [Patch v4 12/12] Documention: v4l: Documentation for HEVC CIDs Smitha T Murthy <smitha.t@samsung.com> - 2017-04-06 08:20 +0200
    Re: [Patch v4 12/12] Documention: v4l: Documentation for HEVC CIDs Hans Verkuil <hverkuil@xs4all.nl> - 2017-04-06 15:40 +0200
      Re: [Patch v4 12/12] Documention: v4l: Documentation for HEVC CIDs Smitha T Murthy <smitha.t@samsung.com> - 2017-04-07 10:40 +0200
    Re: [Patch v4 12/12] Documention: v4l: Documentation for HEVC CIDs Sylwester Nawrocki <s.nawrocki@samsung.com> - 2017-04-06 16:50 +0200
      Re: [Patch v4 12/12] Documention: v4l: Documentation for HEVC CIDs Smitha T Murthy <smitha.t@samsung.com> - 2017-04-07 12:10 +0200
        Re: [Patch v4 12/12] Documention: v4l: Documentation for HEVC CIDs Sylwester Nawrocki <s.nawrocki@samsung.com> - 2017-04-07 12:30 +0200
          Re: [Patch v4 12/12] Documention: v4l: Documentation for HEVC CIDs Smitha T Murthy <smitha.t@samsung.com> - 2017-04-07 14:10 +0200
  [Patch v4 03/12] [media] s5p-mfc: Use min scratch buffer size as  provided by F/W Smitha T Murthy <smitha.t@samsung.com> - 2017-04-06 08:20 +0200
  [Patch v4 09/12] [media] s5p-mfc: Add VP9 decoder support Smitha T Murthy <smitha.t@samsung.com> - 2017-04-06 08:20 +0200
  [Patch v4 04/12] [media] s5p-mfc: Support MFCv10.10 buffer requirements Smitha T Murthy <smitha.t@samsung.com> - 2017-04-06 08:20 +0200

csiph-web