Re: [RFC PATCH 1/6] x86/apic: Replace init_bsp_APIC() with apic_virture_wire_mode_setup()

From	Dou Liyang <douly.fnst@cn.fujitsu.com>
Newsgroups	linux.kernel
Subject	Re: [RFC PATCH 1/6] x86/apic: Replace init_bsp_APIC() with apic_virture_wire_mode_setup()
Date	2017-04-06 03:40 +0200
Message-ID	<tt4yZ-1OU-1@gated-at.bofh.it> (permalink)
References	<tqneO-8iT-11@gated-at.bofh.it> <tqneP-8iT-33@gated-at.bofh.it> <tsQFI-1vp-35@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

Hi Thomas,

Thank you very much!

At 04/05/2017 06:43 PM, Thomas Gleixner wrote:
> On Wed, 29 Mar 2017, Dou Liyang wrote:
>
>> The init_bsp_APIC() setups the virtual wire mode through the local
>> APIC.
>>
>> The function name is unsuitable which might imply that the BSP's
>> APIC will be initialized here, actually, where it will be done is
>> almost at the end of start_kernel(). And the CONFIG X86_64 is also
>> imply the X86_LOCAL_APIC is y.
>
> Correct, but X86_32 can have X86_LOCAL_APIC=n. And by removing the ifdefs
> you break that.
>
>>  /*
>> - * An initial setup of the virtual wire mode.
>> + * Setup the through-local-APIC virtual wire mode.
>>   */
>> -void __init init_bsp_APIC(void)
>> +void apic_virture_wire_mode_setup(void)
>
> s/virture/virtual/ ?

Yes, It is.

>
> Why is this function not longer marked __init ?
>

Oops. The __init is necessary. I will modify it.

Thanks,
	Liyang.


> Thanks,
>
> 	tglx
>
>
>

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[RFC PATCH 1/6] x86/apic: Replace init_bsp_APIC() with apic_virture_wire_mode_setup() Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-03-29 17:00 +0200
  Re: [RFC PATCH 1/6] x86/apic: Replace init_bsp_APIC() with  apic_virture_wire_mode_setup() Thomas Gleixner <tglx@linutronix.de> - 2017-04-05 12:50 +0200
    Re: [RFC PATCH 1/6] x86/apic: Replace init_bsp_APIC() with  apic_virture_wire_mode_setup() Thomas Gleixner <tglx@linutronix.de> - 2017-04-05 13:00 +0200
      Re: [RFC PATCH 1/6] x86/apic: Replace init_bsp_APIC() with  apic_virture_wire_mode_setup() Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-04-06 03:40 +0200
    Re: [RFC PATCH 1/6] x86/apic: Replace init_bsp_APIC() with  apic_virture_wire_mode_setup() Dou Liyang <douly.fnst@cn.fujitsu.com> - 2017-04-06 03:40 +0200

csiph-web