Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]

Groups > linux.kernel > #1617400

Re: [PATCH] mm: vmscan: fix IO/refault regression in cache workingset transition

Show all headers | View raw

[Multipart message — attachments visible in raw view] - view raw

On Tue, 2017-04-04 at 18:00 -0400, Johannes Weiner wrote:

> +
> +	/*
> +	 * When refaults are being observed, it means a new
> workingset
> +	 * is being established. Disable active list protection to
> get
> +	 * rid of the stale workingset quickly.
> +	 */

This looks a little aggressive. What is this
expected to do when you have multiple workloads
sharing the same LRU, and one of the workloads
is doing refaults, while the other workload is
continuing to use the same working set as before?

I have been trying to wrap my mind around that for
the past day or so, and figure I should just ask
the question :)

> +	if (file && actual_reclaim && lruvec->refaults != refaults)
> {
> +		inactive_ratio = 0;
> +	} else {
> +		gb = (inactive + active) >> (30 - PAGE_SHIFT);
> +		if (gb)
> +			inactive_ratio = int_sqrt(10 * gb);
> +		else
> +			inactive_ratio = 1;
> +	}

-- 
All rights reversed

Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread

Thread

[PATCH] mm: vmscan: fix IO/refault regression in cache workingset transition Johannes Weiner <hannes@cmpxchg.org> - 2017-04-05 00:10 +0200
  Re: [PATCH] mm: vmscan: fix IO/refault regression in cache  workingset transition Rik van Riel <riel@redhat.com> - 2017-04-06 00:20 +0200
    Re: [PATCH] mm: vmscan: fix IO/refault regression in cache  workingset transition Johannes Weiner <hannes@cmpxchg.org> - 2017-04-06 16:50 +0200
      Re: [PATCH] mm: vmscan: fix IO/refault regression in cache  workingset transition Rik van Riel <riel@redhat.com> - 2017-04-06 19:00 +0200

csiph-web