[PATCH 06/12] pstore: return error code (if any) from efi_pstore_write

From	Ard Biesheuvel <ard.biesheuvel@linaro.org>
Newsgroups	linux.kernel
Subject	[PATCH 06/12] pstore: return error code (if any) from efi_pstore_write
Date	2017-04-04 18:10 +0200
Message-ID	<tszbR-78Z-47@gated-at.bofh.it> (permalink)
References	<tszbP-78Z-3@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

From: Evgeny Kalugin <evgeny.kalugin@intel.com>

For some reason return value from actual variable setting was ignored.
With this change error code get transferred upwards through call stack.

Signed-off-by: Evgeny Kalugin <evgeny.kalugin@intel.com>
Cc: Matt Fleming <matt@codeblueprint.co.uk>
Signed-off-by: Ard Biesheuvel <ard.biesheuvel@linaro.org>
---
 drivers/firmware/efi/efi-pstore.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/drivers/firmware/efi/efi-pstore.c b/drivers/firmware/efi/efi-pstore.c
index f402ba2eed46..6b5acefce6b3 100644
--- a/drivers/firmware/efi/efi-pstore.c
+++ b/drivers/firmware/efi/efi-pstore.c
@@ -274,9 +274,9 @@ static int efi_pstore_write(enum pstore_type_id type,
 	for (i = 0; i < DUMP_NAME_LEN; i++)
 		efi_name[i] = name[i];
 
-	efivar_entry_set_safe(efi_name, vendor, PSTORE_EFI_ATTRIBUTES,
-			      !pstore_cannot_block_path(reason),
-			      size, psi->buf);
+	ret = efivar_entry_set_safe(efi_name, vendor, PSTORE_EFI_ATTRIBUTES,
+				    !pstore_cannot_block_path(reason),
+				    size, psi->buf);
 
 	if (reason == KMSG_DUMP_OOPS)
 		efivar_run_worker();
-- 
2.9.3

Back to linux.kernel | Previous | Next — Next in thread | Find similar | Unroll thread

Thread

[PATCH 06/12] pstore: return error code (if any) from efi_pstore_write Ard Biesheuvel <ard.biesheuvel@linaro.org> - 2017-04-04 18:10 +0200
  [tip:efi/core] efi/pstore: Return error code (if any) from  efi_pstore_write() tip-bot for Evgeny Kalugin <tipbot@zytor.com> - 2017-04-05 11:10 +0200
  [tip:efi/core] efi/pstore: Return error code (if any) from  efi_pstore_write() tip-bot for Evgeny Kalugin <tipbot@zytor.com> - 2017-04-05 12:50 +0200

csiph-web