Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]


Groups > linux.kernel > #1616090

Re: [PATCH v2] selftests: add a generic testsuite for ethernet device

From Andrew Lunn <andrew@lunn.ch>
Newsgroups linux.kernel
Subject Re: [PATCH v2] selftests: add a generic testsuite for ethernet device
Date 2017-04-04 17:10 +0200
Message-ID <tsyfM-6vk-15@gated-at.bofh.it> (permalink)
References <tswQG-5tl-23@gated-at.bofh.it> <tsxWq-68Z-9@gated-at.bofh.it>
Organization linux.* mail to news gateway

Show all headers | View raw


On Tue, Apr 04, 2017 at 04:43:19PM +0200, Niklas Cassel wrote:
> On 04/04/2017 03:32 PM, Corentin Labbe wrote:
> > This patch add a generic testsuite for testing ethernet network device driver.
> > 
> > Signed-off-by: Corentin Labbe <clabbe.montjoie@gmail.com>
> > ---
> > 
> > Changes since v1:
> > - Test for starting master interface
> > - Changed printing format to "RESULT: $netdev: line"
> > - Use "ip link" to get device list
> > 
> >  tools/testing/selftests/net/Makefile     |   2 +-
> >  tools/testing/selftests/net/netdevice.sh | 200 +++++++++++++++++++++++++++++++
> >  2 files changed, 201 insertions(+), 1 deletion(-)
> >  create mode 100755 tools/testing/selftests/net/netdevice.sh
> > 
> (snip)
> 
> Good work!
> 
> I suggest adding a test for setting MTU as well.

That one might be tricky. Some devices don't allow the MTU to be
changed when the device is up. Others might require the interface is
up...

	Andrew

Back to linux.kernel | Previous | NextPrevious in thread | Next in thread | Find similar | Unroll thread


Thread

[PATCH v2] selftests: add a generic testsuite for ethernet device Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-04 15:40 +0200
  Re: [PATCH v2] selftests: add a generic testsuite for ethernet device Andrew Lunn <andrew@lunn.ch> - 2017-04-04 16:30 +0200
  Re: [PATCH v2] selftests: add a generic testsuite for ethernet device Niklas Cassel <niklas.cassel@axis.com> - 2017-04-04 16:50 +0200
    Re: [PATCH v2] selftests: add a generic testsuite for ethernet device Corentin Labbe <clabbe.montjoie@gmail.com> - 2017-04-04 17:00 +0200
    Re: [PATCH v2] selftests: add a generic testsuite for ethernet device Andrew Lunn <andrew@lunn.ch> - 2017-04-04 17:10 +0200
  Re: [PATCH v2] selftests: add a generic testsuite for ethernet  device David Miller <davem@davemloft.net> - 2017-04-05 17:40 +0200

csiph-web