Re: [PATCH 04+/11] platform/x86: fujitsu-laptop: simplify set_lcd_level()

From	Darren Hart <dvhart@infradead.org>
Newsgroups	linux.kernel
Subject	Re: [PATCH 04+/11] platform/x86: fujitsu-laptop: simplify set_lcd_level()
Date	2017-04-04 17:50 +0200
Message-ID	<tsySu-6KL-17@gated-at.bofh.it> (permalink)
References	<tskcO-5Aq-11@gated-at.bofh.it> <tst6p-2ZU-5@gated-at.bofh.it>
Organization	linux.* mail to news gateway

Show all headers | View raw

On Tue, Apr 04, 2017 at 11:39:03AM +0200, Michał Kępień wrote:
> acpi_execute_simple_method() takes a method parameter which tells it to
> look for the given method underneath the given handle, so calling
> acpi_get_handle() beforehand is redundant.  Replace the call to
> acpi_get_handle() with a call to acpi_execute_simple_method(), thus
> eliminating the need for a local variable storing the handle.  Update
> debug message to reflect this change.  Also do not assign a default
> value to status as it has no influence on execution flow.
> 
> Signed-off-by: Michał Kępień <kernel@kempniu.pl>
> ---
> Darren,
> 
> This is patch 04/11 with updated debug and commit messages.  Now that
> you mentioned this issue, I think we should do the same for patch 2/3 in
> the call_fext_func() cleanup series [1].  Would you like me to just send
> an updated version of that specific patch (similarly to what I did in
> this case) or rather send v2 of the entire call_fext_func() cleanup
> series?

Thanks, looks good.

Now that there is more than one cleanup, please do just send a v2 of the entire
series. Less error prone that way.

Thanks,

-- 
Darren Hart
VMware Open Source Technology Center

Back to linux.kernel | Previous | Next — Previous in thread | Find similar | Unroll thread

Thread

[PATCH 04/11] platform/x86: fujitsu-laptop: simplify set_lcd_level() Michał Kępień <kernel@kempniu.pl> - 2017-03-30 12:40 +0200
  Re: [PATCH 04/11] platform/x86: fujitsu-laptop: simplify  set_lcd_level() Darren Hart <dvhart@infradead.org> - 2017-04-04 02:10 +0200
    [PATCH 04+/11] platform/x86: fujitsu-laptop: simplify set_lcd_level() Michał Kępień <kernel@kempniu.pl> - 2017-04-04 11:40 +0200
      Re: [PATCH 04+/11] platform/x86: fujitsu-laptop: simplify  set_lcd_level() Darren Hart <dvhart@infradead.org> - 2017-04-04 17:50 +0200

csiph-web