Groups | Search | Server Info | Keyboard shortcuts | Login | Register [http] [https] [nntp] [nntps]
Groups > linux.kernel > #1616133
| From | Maxime Ripard <maxime.ripard@free-electrons.com> |
|---|---|
| Newsgroups | linux.kernel |
| Subject | Re: [PATCH v3 2/4] ARM: dts: sun4i: Add can0_pins_a pinctrl settings |
| Date | 2017-04-04 17:50 +0200 |
| Message-ID | <tsySu-6KL-15@gated-at.bofh.it> (permalink) |
| References | <tsbMe-8vF-5@gated-at.bofh.it> <tsbMe-8vF-21@gated-at.bofh.it> |
| Organization | linux.* mail to news gateway |
[Multipart message — attachments visible in raw view] - view raw
On Mon, Apr 03, 2017 at 07:00:12PM +0200, Patrick Menschel wrote:
> The A10 SoC has an on-board CAN controller. This patch adds the
> pinctrl settings for pins PH20 and PH21.
>
> This patch is adapted from the description in
> Documentation/devicetree/bindings/net/can/sun4i_can.txt
>
> Signed-off-by: Patrick Menschel <menschel.p@posteo.de>
> ---
> arch/arm/boot/dts/sun4i-a10.dtsi | 5 +++++
> 1 file changed, 5 insertions(+)
>
> diff --git a/arch/arm/boot/dts/sun4i-a10.dtsi b/arch/arm/boot/dts/sun4i-a10.dtsi
> index 7c559e7..f7dced4 100644
> --- a/arch/arm/boot/dts/sun4i-a10.dtsi
> +++ b/arch/arm/boot/dts/sun4i-a10.dtsi
> @@ -974,6 +974,11 @@
> #interrupt-cells = <3>;
> #gpio-cells = <3>;
>
> + can0_pins_a: can0@0 {
> + pins = "PH20","PH21";
You need a space after the comma here. Fixed and applied.
Maxime
--
Maxime Ripard, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
Back to linux.kernel | Previous | Next — Previous in thread | Next in thread | Find similar | Unroll thread
[PATCH v3 0/4] ARM: dts: sunxi: Add CAN node and can0_pins_a pinctrl settings Patrick Menschel <menschel.p@posteo.de> - 2017-04-03 17:10 +0200
[PATCH v3 1/4] ARM: dts: sun4i: Add CAN node Patrick Menschel <menschel.p@posteo.de> - 2017-04-03 17:10 +0200
Re: [PATCH v3 1/4] ARM: dts: sun4i: Add CAN node Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-04 17:50 +0200
Re: [PATCH v3 1/4] ARM: dts: sun4i: Add CAN node Patrick Menschel <menschel.p@posteo.de> - 2017-04-04 19:00 +0200
[PATCH v3 3/4] ARM: dts: sun7i: Add CAN node Patrick Menschel <menschel.p@posteo.de> - 2017-04-03 17:10 +0200
[PATCH v3 2/4] ARM: dts: sun4i: Add can0_pins_a pinctrl settings Patrick Menschel <menschel.p@posteo.de> - 2017-04-03 17:10 +0200
Re: [PATCH v3 2/4] ARM: dts: sun4i: Add can0_pins_a pinctrl settings Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-04 17:50 +0200
[PATCH v3 4/4] ARM: dts: sun7i: Add can0_pins_a pinctrl settings Patrick Menschel <menschel.p@posteo.de> - 2017-04-03 17:10 +0200
Re: [PATCH v3 4/4] ARM: dts: sun7i: Add can0_pins_a pinctrl settings Maxime Ripard <maxime.ripard@free-electrons.com> - 2017-04-04 17:50 +0200
csiph-web